third_party/ocmock/README.chromium - Issue 958613003: Fix comparison of forward-declared and fully visible types

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/ocmock/README.chromium

Issue 958613003: Fix comparison of forward-declared and fully visible types (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Patch in https://github.com/carllindberg/ocmock/commit/65ee89744bc1fbb9461f26d83e08243068cb212b Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/ocmock/README.chromium

diff --git a/third_party/ocmock/README.chromium b/third_party/ocmock/README.chromium

index dec968a3fa81a1af0701c3f3bad5aed4dc03b04b..65d4126214041e7429ffd19c6c46d91d46579f46 100644

--- a/third_party/ocmock/README.chromium

+++ b/third_party/ocmock/README.chromium

@@ -32,8 +32,5 @@ the comparison of types between invocation return type description (which

changed from "c" to "B" on arm64) and NSValue objCType (which didn't change)

on arm64 for BOOL values.

-Chromium does patch OCMBoxedReturnValueProvider.m to handle comparison of

-return type and value type for C++ objects when compiling with clang and

-using libc++ STL library. The file is renamed OCMBoxedReturnValueProvider.mm

-to be compiled as an Objective-C++ class to allow detection of the C++ STL

-library used. Pull request: https://github.com/erikdoe/ocmock/pull/97

+Chromium also patches in 65ee89744bc1fbb9461f26d83e08243068cb212b that fixes

+the comparison between opaque (forward-declared) and non-opaque types.

« no previous file with comments | « third_party/ocmock/OCMock/OCMBoxedReturnValueProvider.mm ('k') | third_party/ocmock/ocmock.gyp » ('j') | no next file with comments »