Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(741)

Issue 316873003: Add a workaround to compare types in mocked method (Closed)

Created:
6 years, 6 months ago by sdefresne
Modified:
6 years, 5 months ago
Reviewers:
Nico
CC:
chromium-reviews, stuartmorgan, jfroy
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Add a workaround to compare types in mocked method The description of type returned by @encode(__typeof__(expr)) and [[NSInvocation methodSignature] methodReturnType] are not equal for C++ objects when building with libc++. The value returned by methodSignature does not expand some internal template parameters. When comparing the types are the same, we do not really care about the type implementation, just that the types are the same (ie. same global name), so just ignore all expansions. BUG=377691 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=279796

Patch Set 1 #

Patch Set 2 : Add note in README.chromium and sync with upstream pull request #

Unified diffs Side-by-side diffs Delta from patch set Stats (+152 lines, -25 lines) Patch
D third_party/ocmock/OCMock/OCMBoxedReturnValueProvider.m View 1 chunk +0 lines, -24 lines 0 comments Download
A third_party/ocmock/OCMock/OCMBoxedReturnValueProvider.mm View 1 1 chunk +145 lines, -0 lines 0 comments Download
M third_party/ocmock/README.chromium View 1 1 chunk +6 lines, -0 lines 0 comments Download
M third_party/ocmock/ocmock.gyp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
sdefresne
thakis: PTAL stuartmorgan, jfroy: FYI on how I plan to fix http://crbug.com/377691
6 years, 6 months ago (2014-06-04 14:08:46 UTC) #1
Nico
Did you try to send this to upstream ocmock?
6 years, 6 months ago (2014-06-04 22:15:34 UTC) #2
sdefresne
Reported as https://github.com/erikdoe/ocmock/issues/96 and sent a pull request.
6 years, 6 months ago (2014-06-23 10:01:19 UTC) #3
Nico
lgtm with link to pull request in readme Thanks!
6 years, 6 months ago (2014-06-23 15:54:47 UTC) #4
sdefresne
The CQ bit was checked by sdefresne@chromium.org
6 years, 5 months ago (2014-06-25 17:36:59 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sdefresne@chromium.org/316873003/10001
6 years, 5 months ago (2014-06-25 17:37:49 UTC) #6
commit-bot: I haz the power
6 years, 5 months ago (2014-06-25 20:23:21 UTC) #7
Message was sent while issue was closed.
Change committed as 279796

Powered by Google App Engine
This is Rietveld 408576698