Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(209)

Issue 958463002: Cleanup transform-related methods in RenderLayer. (Closed)

Created:
5 years, 10 months ago by ojan
Modified:
5 years, 10 months ago
Reviewers:
abarth-chromium
CC:
abarth-chromium, esprehn, mojo-reviews_chromium.org, qsr+mojo_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Cleanup transform-related methods in RenderLayer. -Get rid of paintsWithTransform. -Remove currentTransform. It was only ever called with IncludeTransformOrigin and on non-null transforms. -Remove renderableTransform. It was only called on non-null transforms. -Remove a layer()->parent() branch. The ASSERT had been added in a previous patch, but the branch wasn't removed. -Inline makeMatrixRenderable. It was only called in one place. -Add a test to make sure that transform origin is corrrectly excluded from the transform computedStyle. R=abarth@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/4e0a4feff24e6e66c6efe075798bc611613fc4a0

Patch Set 1 #

Patch Set 2 : improve test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+76 lines, -62 lines) Patch
M sky/engine/core/rendering/RenderBox.cpp View 4 chunks +7 lines, -11 lines 0 comments Download
M sky/engine/core/rendering/RenderLayer.h View 2 chunks +1 line, -8 lines 0 comments Download
M sky/engine/core/rendering/RenderLayer.cpp View 6 chunks +6 lines, -34 lines 0 comments Download
M sky/engine/core/rendering/RenderObject.h View 1 chunk +0 lines, -7 lines 0 comments Download
M sky/engine/core/rendering/RenderObject.cpp View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/core/rendering/RenderView.cpp View 1 chunk +1 line, -1 line 0 comments Download
A sky/tests/styles/transforms.sky View 1 1 chunk +52 lines, -0 lines 0 comments Download
A sky/tests/styles/transforms-expected.txt View 1 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (1 generated)
abarth-chromium
lgtm
5 years, 10 months ago (2015-02-24 22:28:44 UTC) #2
ojan
5 years, 10 months ago (2015-02-24 22:31:53 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
4e0a4feff24e6e66c6efe075798bc611613fc4a0 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698