sky/engine/core/rendering/RenderObject.cpp - Issue 958463002: Cleanup transform-related methods in RenderLayer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sky/engine/core/rendering/RenderObject.cpp

Issue 958463002: Cleanup transform-related methods in RenderLayer. (Closed) Base URL: git@github.com:domokit/mojo.git@master

Patch Set: improve test Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sky/engine/core/rendering/RenderObject.cpp

diff --git a/sky/engine/core/rendering/RenderObject.cpp b/sky/engine/core/rendering/RenderObject.cpp

index 3127781ebf166ff04bc45035843e9430d82bab1d..9a6ca0bbed58076462ee1c171c84c0b303126210 100644

--- a/sky/engine/core/rendering/RenderObject.cpp

+++ b/sky/engine/core/rendering/RenderObject.cpp

@@ -1427,7 +1427,7 @@ void RenderObject::getTransformFromContainer(const RenderObject* containerObject

transform.translate(offsetInContainer.width().toFloat(), offsetInContainer.height().toFloat());

RenderLayer* layer = hasLayer() ? toRenderBox(this)->layer() : 0;

if (layer && layer->transform())

- transform.multiply(layer->currentTransform());

+ transform.multiply(*layer->transform());

if (containerObject && containerObject->hasLayer() && containerObject->style()->hasPerspective()) {

// Perpsective on the container affects us, so we have to factor it in here.

« no previous file with comments | « sky/engine/core/rendering/RenderObject.h ('k') | sky/engine/core/rendering/RenderView.cpp » ('j') | no next file with comments »