sky/engine/core/rendering/RenderObject.h - Issue 958463002: Cleanup transform-related methods in RenderLayer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sky/engine/core/rendering/RenderObject.h

Issue 958463002: Cleanup transform-related methods in RenderLayer. (Closed) Base URL: git@github.com:domokit/mojo.git@master

Patch Set: improve test Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sky/engine/core/rendering/RenderObject.h

diff --git a/sky/engine/core/rendering/RenderObject.h b/sky/engine/core/rendering/RenderObject.h

index c2f51dc9ef55f79335cc6e4636c37ff521d08446..abd90249658d3f6c47a1e6c8993f1b0febd35ef0 100644

--- a/sky/engine/core/rendering/RenderObject.h

+++ b/sky/engine/core/rendering/RenderObject.h

@@ -880,13 +880,6 @@ inline void RenderObject::setSelectionStateIfNeeded(SelectionState state)

setSelectionState(state);

}

-inline void makeMatrixRenderable(TransformationMatrix& matrix)

- // FIXME(sky): We shouldn't need to do this once Skia has 4x4 matrix support.

- // Until then, 3d transforms don't work right.

- matrix.makeAffine();

#define DEFINE_RENDER_OBJECT_TYPE_CASTS(thisType, predicate) \

DEFINE_TYPE_CASTS(thisType, RenderObject, object, object->predicate, object.predicate)