Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1541)

Unified Diff: scripts/slave/recipe_modules/ios/api.py

Issue 957493002: Add analyze steps to iOS try bot builds which use ninja (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/build
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: scripts/slave/recipe_modules/ios/api.py
diff --git a/scripts/slave/recipe_modules/ios/api.py b/scripts/slave/recipe_modules/ios/api.py
index 6a4825e77f65182471ccd5c0b1eb5d036fcf4b56..55bcade74945c2116db7ddfc094abe0f6f624d0b 100644
--- a/scripts/slave/recipe_modules/ios/api.py
+++ b/scripts/slave/recipe_modules/ios/api.py
@@ -122,7 +122,7 @@ class iOSApi(recipe_api.RecipeApi):
'--version', self.__config['xcode version'],
], step_test_data=lambda: self.m.json.test_api.output({}))
- def build(self, official=False):
smut 2015/02/24 19:37:01 We were only using the official kwarg downstream.
+ def build(self):
"""Builds from this bot's build config."""
assert self.__config is not None
@@ -171,6 +171,19 @@ class iOSApi(recipe_api.RecipeApi):
'<br />GYP_DEFINES:<br />%s' % '<br />'.join(gyp_defines)
)
+ if self.compiler == 'ninja' and self.m.tryserver.is_tryserver:
+ tests = [test['app'] for test in self.__config['tests']]
+ self.m.filter.does_patch_require_compile(
Paweł Hajdan Jr. 2015/02/25 15:23:37 Consider using "analyze" from chromium_tests. It a
smut 2015/02/25 18:46:49 Done.
+ compile_targets=tests,
+ exes=tests,
+ set_env=False,
+ )
+
+ if self.m.filter.result:
+ self.m.step('matching exes', ['echo'] + self.m.filter.matching_exes)
+ self.m.step('compile targets', ['echo'] + self.m.filter.compile_targets)
+ self.m.step('paths', ['echo'] + self.m.filter.paths)
+
self.m.step('compile', cmd, cwd=cwd)
def test(self, *args):

Powered by Google App Engine
This is Rietveld 408576698