Add analyze steps to iOS try bot builds which use ninja

scripts/slave/recipe_modules/filter/api.py

Index: scripts/slave/recipe_modules/filter/api.py
diff --git a/scripts/slave/recipe_modules/filter/api.py b/scripts/slave/recipe_modules/filter/api.py
index c5e1a59e0c68b2b52a235206b3d330697213f956..d0473ce96b3fe27d9de57fe832c4e814b3f216e9 100644
--- a/scripts/slave/recipe_modules/filter/api.py
+++ b/scripts/slave/recipe_modules/filter/api.py
@@ -73,6 +73,7 @@ class FilterApi(recipe_api.RecipeApi):
   def does_patch_require_compile(self, exes=None, compile_targets=None,
                                  additional_name=None,
                                  config_file_name='trybot_analyze_config.json',
+                                 set_env=True,
                                  **kwargs):
     """Return true if the current patch requires a build (and exes to run).
     Return value can be accessed by call to result().
@@ -135,8 +136,9 @@ class FilterApi(recipe_api.RecipeApi):
                    'targets': [],
                    'build_targets': []}
 
-    kwargs.setdefault('env', {})
-    kwargs['env'].update(self.m.chromium.c.gyp_env.as_jsonish())
+    if set_env:

[smut, 2015/02/24 19:37:01]

Added this because iOS recipes do not have a Chromium config set. I'd rather not
set it right now because iOS's gyp environment variables are very specific and
what we have is currently working.

[Paweł Hajdan Jr., 2015/02/25 15:23:37]

Before the ios recipes we had ios build on main waterfall and trybots using the
chromium config. What is preventing us from doing the same here?

[smut, 2015/02/25 18:46:49]

For one, the GYP_DEFINES are set by the developers in config files that live in
the Chromium repository. I don't want to use the Chromium recipe config because
it makes other decisions about the values of those variables.

I also don't want to regress on something that's working. We really need to get
this stuff up and running because many outstanding bugs depend on it.

[Paweł Hajdan Jr., 2015/02/26 21:42:04]

I'm really concerned about this.

Using GYP_DEFINES from chromium repo sounds fine. Why not just put the value
obtained from that into GYP_DEFINES in chromium recipe module config?

This would allow us to re-use all the existing infrastructure that respects the
config (note that in most places we just read the values - you don't have to use
the "mainstream" ways of setting GYP_DEFINES in chromium config, it's fine to
put your own value there), as opposed to introducing even more special cases
throughout the modules.
 
Makes sense to me. I'm just thinking about the best way to integrate it.

[smut, 2015/02/27 00:30:01]

Okay, that makes sense. I thought you wanted me to change it around so we use
configs. If you just want the GYP_DEFINES that are read from the source
repository set in the config, then that should be okay. I've done that.

+      kwargs.setdefault('env', {})
+      kwargs['env'].update(self.m.chromium.c.gyp_env.as_jsonish())
 
     try:
       step_result = self.m.python('analyze',