Add analyze steps to iOS try bot builds which use ninja

scripts/slave/recipe_modules/ios/api.py

 # Copyright 2015 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 from slave import recipe_api
 
 
 class iOSApi(recipe_api.RecipeApi):
   def __init__(self, *args, **kwargs):
     super(iOSApi, self).__init__(*args, **kwargs)
@@ skipping 104 matching lines @@
       self.m.path['build'].join(
         'scripts',
         'slave',
         'ios',
         'find_xcode.py',
       ),
       '--json-file', self.m.json.output(),
       '--version', self.__config['xcode version'],
     ], step_test_data=lambda: self.m.json.test_api.output({}))
 
-  def build(self, official=False):

[smut, 2015/02/24 19:37:01]

We were only using the official kwarg downstream. This shouldn't have been
upstreamed in the first place.

+  def build(self):
     """Builds from this bot's build config."""
     assert self.__config is not None
 
     # Add the default GYP_DEFINES.
     gyp_defines = [
       'component=static_library',
       'OS=ios',
     ]
 
     gyp_defines.extend(
@@ skipping 28 matching lines @@
           'device': 'iphoneos',
         }[self.platform])
       )
       cmd = ['ninja', '-C', cwd]
 
     step_result = self.m.gclient.runhooks(env=env)
     step_result.presentation.step_text = (
       '<br />GYP_DEFINES:<br />%s' % '<br />'.join(gyp_defines)
     )
 
+    if self.compiler == 'ninja' and self.m.tryserver.is_tryserver:
+      tests = [test['app'] for test in self.__config['tests']]
+      self.m.filter.does_patch_require_compile(

[Paweł Hajdan Jr., 2015/02/25 15:23:37]

Consider using "analyze" from chromium_tests. It already prints useful debugging
info.

[smut, 2015/02/25 18:46:49]

Done.

+        compile_targets=tests,
+        exes=tests,
+        set_env=False,
+      )
+
+      if self.m.filter.result:
+        self.m.step('matching exes', ['echo'] + self.m.filter.matching_exes)
+        self.m.step('compile targets', ['echo'] + self.m.filter.compile_targets)
+        self.m.step('paths', ['echo'] + self.m.filter.paths)
+
     self.m.step('compile', cmd, cwd=cwd)
 
   def test(self, *args):
     """Runs tests as instructed by this bot's build config.
 
     Args:
       *args: Any additional arguments to pass to the test harness.
     """
     assert self.__config is not None
     test_failures = []
@@ skipping 125 matching lines @@
         self.configuration,
         'iossim',
       ),
       'ninja': self.m.path.join(
         'src',
          build_dir,
          '%s-%s' % (self.configuration, platform),
          'iossim',
       ),
     }[self.compiler]