Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(273)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 956653003: Dart: Moves |native| methods to patch files. (Closed)

Created:
5 years, 10 months ago by zra
Modified:
5 years, 9 months ago
CC:
mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, esprehn, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org, ojan
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Dart: Moves |native| methods to patch files. This change also enables patch file loading for Sky. This change is needed to eliminate spurious errors from dartanalyer regarding |native| appearing outside of the Dart SDK, etc. BUG=

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : Adjust analyzer script #

Unified diffs Side-by-side diffs Delta from patch set Stats (+325 lines, -113 lines) Patch
M mojo/dart/embedder/core/buffer_patch.dart View 1 chunk +17 lines, -0 lines 0 comments Download
M mojo/dart/embedder/core/data_pipe_patch.dart View 1 chunk +23 lines, -0 lines 0 comments Download
M mojo/dart/embedder/core/handle_patch.dart View 1 chunk +9 lines, -0 lines 0 comments Download
M mojo/dart/embedder/core/handle_watcher_patch.dart View 1 chunk +11 lines, -0 lines 0 comments Download
M mojo/dart/embedder/core/message_pipe_patch.dart View 1 chunk +12 lines, -0 lines 0 comments Download
M mojo/public/dart/src/buffer.dart View 4 chunks +10 lines, -17 lines 0 comments Download
M mojo/public/dart/src/data_pipe.dart View 1 9 chunks +33 lines, -33 lines 0 comments Download
M mojo/public/dart/src/handle.dart View 1 1 chunk +5 lines, -6 lines 0 comments Download
M mojo/public/dart/src/handle_watcher.dart View 1 1 chunk +5 lines, -7 lines 0 comments Download
M mojo/public/dart/src/message_pipe.dart View 4 chunks +19 lines, -18 lines 0 comments Download
M mojo/public/tools/dart_analyze.py View 1 2 1 chunk +2 lines, -4 lines 0 comments Download
M sky/engine/bindings/BUILD.gn View 1 2 chunks +58 lines, -0 lines 0 comments Download
M sky/engine/bindings/builtin.h View 1 chunk +13 lines, -2 lines 0 comments Download
M sky/engine/bindings/builtin.cc View 1 1 chunk +100 lines, -17 lines 0 comments Download
M sky/engine/bindings/builtin_natives.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/bindings/builtin_sky.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M sky/engine/core/script/dart_controller.cc View 1 3 chunks +5 lines, -6 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
zra
This is the second of two changes needed to make the analyzer a bit happier. ...
5 years, 10 months ago (2015-02-24 19:17:48 UTC) #2
zra
Ping.
5 years, 9 months ago (2015-02-26 19:37:16 UTC) #3
Elliot Glaysher
On 2015/02/26 19:37:16, zra wrote: > Ping. lgtm
5 years, 9 months ago (2015-02-26 19:59:24 UTC) #4
zra
5 years, 9 months ago (2015-03-02 17:25:58 UTC) #5 
Based on discussion on Friday, instead of pursuing this approach, I'll be
backing out the patch file changes, and using a different way of allowing the
analyzer to be happy with the |native| keyword.

Powered by Google App Engine
This is Rietveld 408576698