Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(980)

Unified Diff: mojo/public/dart/src/buffer.dart

Issue 956653003: Dart: Moves |native| methods to patch files. (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Adjust analyzer script Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « mojo/dart/embedder/core/message_pipe_patch.dart ('k') | mojo/public/dart/src/data_pipe.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/public/dart/src/buffer.dart
diff --git a/mojo/public/dart/src/buffer.dart b/mojo/public/dart/src/buffer.dart
index 44673157e5c5b34afa0c56ff42184add3ab9d821..a396dea8247c82ed7a24c75a83bc46cd192e2d65 100644
--- a/mojo/public/dart/src/buffer.dart
+++ b/mojo/public/dart/src/buffer.dart
@@ -5,21 +5,14 @@
part of core;
class _MojoSharedBufferNatives {
- static List Create(int numBytes, int flags)
- native "MojoSharedBuffer_Create";
+ external static List Create(int numBytes, int flags);
- static List Duplicate(int bufferHandle, int flags)
- native "MojoSharedBuffer_Duplicate";
+ external static List Duplicate(int bufferHandle, int flags);
- static List Map(MojoSharedBuffer buffer,
- int bufferHandle,
- int offset,
- int numBytes,
- int flags)
- native "MojoSharedBuffer_Map";
+ external static List Map(MojoSharedBuffer buffer, int bufferHandle,
+ int offset, int numBytes, int flags);
- static int Unmap(ByteData buffer)
- native "MojoSharedBuffer_Unmap";
+ external static int Unmap(ByteData buffer);
}
@@ -32,8 +25,8 @@ class MojoSharedBuffer {
MojoResult status;
ByteData mapping;
- MojoSharedBuffer(
- this.handle, [this.status = MojoResult.OK, this.mapping = null]);
+ MojoSharedBuffer(this.handle, [this.status = MojoResult.OK, this.mapping =
+ null]);
factory MojoSharedBuffer.create(int numBytes, [int flags = 0]) {
List result = _MojoSharedBufferNatives.Create(numBytes, flags);
@@ -58,7 +51,7 @@ class MojoSharedBuffer {
}
assert((result is List) && (result.length == 2));
var r = new MojoResult(result[0]);
- if(!r.isOk) {
+ if (!r.isOk) {
return null;
}
@@ -83,8 +76,8 @@ class MojoSharedBuffer {
status = MojoResult.INVALID_ARGUMENT;
return status;
}
- List result = _MojoSharedBufferNatives.Map(
- this, handle.h, offset, numBytes, flags);
+ List result =
+ _MojoSharedBufferNatives.Map(this, handle.h, offset, numBytes, flags);
if (result == null) {
status = MojoResult.INVALID_ARGUMENT;
return status;
« no previous file with comments | « mojo/dart/embedder/core/message_pipe_patch.dart ('k') | mojo/public/dart/src/data_pipe.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698