mojo/public/tools/dart_analyze.py - Issue 956653003: Dart: Moves |native| methods to patch files.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/public/tools/dart_analyze.py

Issue 956653003: Dart: Moves |native| methods to patch files. (Closed) Base URL: git@github.com:domokit/mojo.git@master

Patch Set: Adjust analyzer script Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: mojo/public/tools/dart_analyze.py

diff --git a/mojo/public/tools/dart_analyze.py b/mojo/public/tools/dart_analyze.py

index 8b8117e205cd0f6a282ba4102bd0ec0987fc8a91..fee6a78b5cea8b651e3ab8614511d190287f21fa 100755

--- a/mojo/public/tools/dart_analyze.py

+++ b/mojo/public/tools/dart_analyze.py

@@ -47,10 +47,8 @@ def main(args):

filtered_lines = [i for i in raw_lines if (

not re.match(_ANALYZING_PATTERN, i) and

not re.match(_FINAL_REPORT_PATTERN, i) and

- # TODO(erg): Remove the rest of these as fixes land:

- not re.match(_WARNING_PATTERN, i) and

- not re.match(_NATIVE_ERROR_PATTERN, i) and

- not re.match(_THAT_ONE_BROKEN_CLOSE_IN_WEB_SOCKETS_PATTERN, i))]

+ # TODO(zra, erg): Fix warnings.

+ not re.match(_WARNING_PATTERN, i))]

for line in filtered_lines:

passed = False

print >> sys.stderr, line

« no previous file with comments | « mojo/public/dart/src/message_pipe.dart ('k') | sky/engine/bindings/BUILD.gn » ('j') | no next file with comments »