Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(317)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 956083002: Revert of Pass clip to context (Closed)

Created:
5 years, 10 months ago by joshualitt
Modified:
5 years, 10 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@pass_down_rendertarget
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of Pass clip to context (patchset #8 id:180001 of https://codereview.chromium.org/936943002/) Reason for revert: Strange blur problems on nexus 5 Original issue's description: > I'd really like to land this before the branch so speedy reviews are appreciated. > > BUG=skia: > > Committed: https://skia.googlesource.com/skia/+/586d5d640b19860dfbbd903a5188da1bbbe87336 TBR=jvanverth@google.com,senorblanco@google.com,bsalomon@google.com,senorblanco@chromium.org,joshualitt@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Committed: https://skia.googlesource.com/skia/+/2907059d0eb1972a300ea1bf0cd4e4febabb9784

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+290 lines, -359 lines) Patch
M gm/texdata.cpp View 3 chunks +3 lines, -4 lines 0 comments Download
M include/core/SkMaskFilter.h View 3 chunks +0 lines, -3 lines 0 comments Download
M include/core/SkRect.h View 1 chunk +0 lines, -10 lines 0 comments Download
M include/gpu/GrClip.h View 9 chunks +8 lines, -33 lines 0 comments Download
M include/gpu/GrContext.h View 13 chunks +73 lines, -18 lines 0 comments Download
M src/core/SkImageFilter.cpp View 3 chunks +3 lines, -6 lines 0 comments Download
M src/core/SkMaskFilter.cpp View 2 chunks +0 lines, -2 lines 0 comments Download
M src/effects/SkAlphaThresholdFilter.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M src/effects/SkBlurMaskFilter.cpp View 7 chunks +5 lines, -8 lines 0 comments Download
M src/effects/SkDisplacementMapEffect.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M src/effects/SkGpuBlurUtils.cpp View 11 chunks +18 lines, -24 lines 0 comments Download
M src/effects/SkMorphologyImageFilter.cpp View 7 chunks +13 lines, -19 lines 0 comments Download
M src/effects/SkXfermodeImageFilter.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrBitmapTextContext.h View 1 chunk +3 lines, -3 lines 0 comments Download
M src/gpu/GrBitmapTextContext.cpp View 6 chunks +10 lines, -10 lines 0 comments Download
M src/gpu/GrClip.cpp View 2 chunks +2 lines, -9 lines 0 comments Download
M src/gpu/GrClipMaskManager.cpp View 1 chunk +22 lines, -40 lines 0 comments Download
M src/gpu/GrContext.cpp View 28 chunks +31 lines, -47 lines 0 comments Download
M src/gpu/GrDistanceFieldTextContext.h View 1 chunk +3 lines, -3 lines 0 comments Download
M src/gpu/GrDistanceFieldTextContext.cpp View 6 chunks +9 lines, -11 lines 0 comments Download
M src/gpu/GrPipelineBuilder.h View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrPipelineBuilder.cpp View 2 chunks +4 lines, -2 lines 0 comments Download
M src/gpu/GrStencilAndCoverTextContext.h View 1 chunk +4 lines, -4 lines 0 comments Download
M src/gpu/GrStencilAndCoverTextContext.cpp View 6 chunks +4 lines, -7 lines 0 comments Download
M src/gpu/GrTextContext.h View 4 chunks +7 lines, -10 lines 0 comments Download
M src/gpu/GrTextContext.cpp View 5 chunks +10 lines, -12 lines 0 comments Download
M src/gpu/SkGpuDevice.h View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/SkGpuDevice.cpp View 28 chunks +35 lines, -42 lines 0 comments Download
M src/gpu/SkGr.cpp View 3 chunks +7 lines, -4 lines 0 comments Download
M src/gpu/effects/GrConfigConversionEffect.cpp View 2 chunks +5 lines, -15 lines 0 comments Download
M tests/ClipCacheTest.cpp View 1 chunk +5 lines, -5 lines 0 comments Download
M tests/GLProgramsTest.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
joshualitt
Created Revert of Pass clip to context
5 years, 10 months ago (2015-02-25 21:03:48 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/956083002/1
5 years, 10 months ago (2015-02-25 21:04:23 UTC) #2
commit-bot: I haz the power
5 years, 10 months ago (2015-02-25 21:04:49 UTC) #3
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/2907059d0eb1972a300ea1bf0cd4e4febabb9784

Powered by Google App Engine
This is Rietveld 408576698