Do not register IME app window in launcher

Do not register IME app window in launcher

BUG=461865
TEST:
1. enable physical keyboard autocorrect feature from IME settings from chrome-extension://jkghodnilhceideoidjikpgommlajknk/hmm_options.html?code=xkb:us::eng
2. type "waht" and wait for a grey triangle appear underneath "waht"
At this point, an IME window is created.
3. verify no default app icon appear in launcher for the IME window

Committed: https://crrev.com/97874ef0c1f4fd88f2d620593c1b7b49b2fdc90a
Cr-Commit-Position: refs/heads/master@{#318734}

[bshe, 2015-02-25 20:00:11]

bshe@chromium.org changed reviewers:
+ benwells@chromium.org, skuhne@chromium.org

[bshe, 2015-02-25 20:00:12]

+benwells for overall review
+skuhne for app_window_launcher_controller.cc

The idea is to disable app window icon in launcher for IME windows. Not sure if
this is the correct way to do it. PTAL

Thanks!

[benwells, 2015-02-26 07:35:23]

lgtm

[bshe, 2015-03-02 16:29:21]

On 2015/02/26 07:35:23, benwells wrote:
> lgtm

frindely ping? Stefan, could you please take a look?

[Mr4D (OOO till 08-26), 2015-03-02 16:44:13]

Thanks for reminding and sorry for that - somehow this slipped through the
cracks.

See comment.

https://codereview.chromium.org/955983004/diff/20001/extensions/browser/app_w...
File extensions/browser/app_window/app_window.h (right):

https://codereview.chromium.org/955983004/diff/20001/extensions/browser/app_w...
extensions/browser/app_window/app_window.h:354: // Whether the app window is
created by IME extensions.
Hmm. Since there is only a single use case for this yet - maybe we should name
this "hide_app_window_in_launcher()" (and also name the var accordingly)?

If you have the feeling that the "ime" information is more valuable however you
can leave that.

[bshe, 2015-03-02 17:39:46]

Patchset #3 (id:40001) has been deleted

[bshe, 2015-03-02 17:40:36]

https://codereview.chromium.org/955983004/diff/20001/extensions/browser/app_w...
File extensions/browser/app_window/app_window.h (right):

https://codereview.chromium.org/955983004/diff/20001/extensions/browser/app_w...
extensions/browser/app_window/app_window.h:354: // Whether the app window is
created by IME extensions.
On 2015/03/02 16:44:12, Mr4D wrote:
> Hmm. Since there is only a single use case for this yet - maybe we should name
> this "hide_app_window_in_launcher()" (and also name the var accordingly)?
> 
> If you have the feeling that the "ime" information is more valuable however
you
> can leave that.

Right. It is only used for one case now. But I am in the process of developing
new keyboard and we might need it to do more customization for IME windows, i.e.
always on top, movable. So I am in favor of keeping the ime name for now. If
later I found no other use case, I will change it to
hide_app_window_in_launcher. Added a todo.

[Mr4D (OOO till 08-26), 2015-03-02 17:50:04]

lgtm

thanks!

[bshe, 2015-03-02 18:15:21]

The CQ bit was checked by bshe@chromium.org

[bshe, 2015-03-02 18:15:21]

The patchset sent to the CQ was uploaded after l-g-t-m from
benwells@chromium.org
Link to the patchset: https://codereview.chromium.org/955983004/#ps60001 (title:
"Add TODO")

[commit-bot: I haz the power, 2015-03-02 18:16:11]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/955983004/60001

[commit-bot: I haz the power, 2015-03-02 19:18:52]

Committed patchset #3 (id:60001)

[commit-bot: I haz the power, 2015-03-02 19:19:27]

Patchset 3 (id:??) landed as
https://crrev.com/97874ef0c1f4fd88f2d620593c1b7b49b2fdc90a
Cr-Commit-Position: refs/heads/master@{#318734}