Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(911)

Unified Diff: extensions/browser/app_window/app_window.h

Issue 955983004: Do not register IME app window in launcher (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add TODO Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/browser/app_window/app_window.h
diff --git a/extensions/browser/app_window/app_window.h b/extensions/browser/app_window/app_window.h
index 8d6ffea1c08b24193b260e1407a89693d3f0ac21..bf78e96ff1456e0cff586dd34aa5f6d8c0d66514 100644
--- a/extensions/browser/app_window/app_window.h
+++ b/extensions/browser/app_window/app_window.h
@@ -351,6 +351,12 @@ class AppWindow : public content::NotificationObserver,
// Whether the app window wants to be alpha enabled.
bool requested_alpha_enabled() const { return requested_alpha_enabled_; }
+ // Whether the app window is created by IME extensions.
+ // TODO(bshe): rename to hide_app_window_in_launcher if it is not used
+ // anywhere other than app_window_launcher_controller after M45. Otherwise,
+ // remove this TODO.
+ bool is_ime_window() const { return is_ime_window_; }
+
void SetAppWindowContentsForTesting(scoped_ptr<AppWindowContents> contents) {
app_window_contents_ = contents.Pass();
}
@@ -555,6 +561,9 @@ class AppWindow : public content::NotificationObserver,
// Whether |alpha_enabled| was set in the CreateParams.
bool requested_alpha_enabled_;
+ // Whether |is_ime_window| was set in the CreateParams.
+ bool is_ime_window_;
+
base::WeakPtrFactory<AppWindow> image_loader_ptr_factory_;
DISALLOW_COPY_AND_ASSIGN(AppWindow);
« no previous file with comments | « chrome/browser/ui/ash/launcher/app_window_launcher_controller.cc ('k') | extensions/browser/app_window/app_window.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698