Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(283)

Side by Side Diff: extensions/browser/app_window/app_window.h

Issue 955983004: Do not register IME app window in launcher (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add TODO Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef EXTENSIONS_BROWSER_APP_WINDOW_APP_WINDOW_H_ 5 #ifndef EXTENSIONS_BROWSER_APP_WINDOW_APP_WINDOW_H_
6 #define EXTENSIONS_BROWSER_APP_WINDOW_APP_WINDOW_H_ 6 #define EXTENSIONS_BROWSER_APP_WINDOW_APP_WINDOW_H_
7 7
8 #include <string> 8 #include <string>
9 #include <vector> 9 #include <vector>
10 10
(...skipping 333 matching lines...) Expand 10 before | Expand all | Expand 10 after
344 // the renderer. 344 // the renderer.
345 void GetSerializedState(base::DictionaryValue* properties) const; 345 void GetSerializedState(base::DictionaryValue* properties) const;
346 346
347 // Called by the window API when events can be sent to the window for this 347 // Called by the window API when events can be sent to the window for this
348 // app. 348 // app.
349 void WindowEventsReady(); 349 void WindowEventsReady();
350 350
351 // Whether the app window wants to be alpha enabled. 351 // Whether the app window wants to be alpha enabled.
352 bool requested_alpha_enabled() const { return requested_alpha_enabled_; } 352 bool requested_alpha_enabled() const { return requested_alpha_enabled_; }
353 353
354 // Whether the app window is created by IME extensions.
355 // TODO(bshe): rename to hide_app_window_in_launcher if it is not used
356 // anywhere other than app_window_launcher_controller after M45. Otherwise,
357 // remove this TODO.
358 bool is_ime_window() const { return is_ime_window_; }
359
354 void SetAppWindowContentsForTesting(scoped_ptr<AppWindowContents> contents) { 360 void SetAppWindowContentsForTesting(scoped_ptr<AppWindowContents> contents) {
355 app_window_contents_ = contents.Pass(); 361 app_window_contents_ = contents.Pass();
356 } 362 }
357 363
358 protected: 364 protected:
359 ~AppWindow() override; 365 ~AppWindow() override;
360 366
361 private: 367 private:
362 // PlatformAppBrowserTest needs access to web_contents() 368 // PlatformAppBrowserTest needs access to web_contents()
363 friend class PlatformAppBrowserTest; 369 friend class PlatformAppBrowserTest;
(...skipping 184 matching lines...) Expand 10 before | Expand all | Expand 10 after
548 // Cache the desired value of the always-on-top property. When windows enter 554 // Cache the desired value of the always-on-top property. When windows enter
549 // fullscreen or overlap the Windows taskbar, this property will be 555 // fullscreen or overlap the Windows taskbar, this property will be
550 // automatically and silently switched off for security reasons. It is 556 // automatically and silently switched off for security reasons. It is
551 // reinstated when the window exits fullscreen and moves away from the 557 // reinstated when the window exits fullscreen and moves away from the
552 // taskbar. 558 // taskbar.
553 bool cached_always_on_top_; 559 bool cached_always_on_top_;
554 560
555 // Whether |alpha_enabled| was set in the CreateParams. 561 // Whether |alpha_enabled| was set in the CreateParams.
556 bool requested_alpha_enabled_; 562 bool requested_alpha_enabled_;
557 563
564 // Whether |is_ime_window| was set in the CreateParams.
565 bool is_ime_window_;
566
558 base::WeakPtrFactory<AppWindow> image_loader_ptr_factory_; 567 base::WeakPtrFactory<AppWindow> image_loader_ptr_factory_;
559 568
560 DISALLOW_COPY_AND_ASSIGN(AppWindow); 569 DISALLOW_COPY_AND_ASSIGN(AppWindow);
561 }; 570 };
562 571
563 } // namespace extensions 572 } // namespace extensions
564 573
565 #endif // EXTENSIONS_BROWSER_APP_WINDOW_APP_WINDOW_H_ 574 #endif // EXTENSIONS_BROWSER_APP_WINDOW_APP_WINDOW_H_
OLDNEW
« no previous file with comments | « chrome/browser/ui/ash/launcher/app_window_launcher_controller.cc ('k') | extensions/browser/app_window/app_window.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698