Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(322)

Issue 954943003: [KeyboardEvent] Use DOM |code| rather than Windows-based key code (Closed)

Created:
5 years, 10 months ago by Habib Virji
Modified:
5 years, 7 months ago
Reviewers:
Wez, kpschoedel
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, creis+watch_chromium.org, tdresser+watch_chromium.org, tfarina, nasko+codewatch_chromium.org, jam, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org, kalyank, jdduke+watch_chromium.org, ozone-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[KeyboardEvent] Use DOM |code| rather than Windows-based key code & introduce XKB support to generate value for DomKey in X11 - Instead of relying on the Windows KeyCode uses Dom |code| to convert to the character. - Introduces helper functions to get the meaning of a DOM |code| in a platform independent way. It supports control characters as well. It assumes a US keyboard layout is used, so it may only be used when there is no native event or no better way to get the character. - The table it uses are responsible for converting are: Dom |code| to a printable character, Dom |code| to Dom |key|, Dom |code| to VKeys, and definitions of the xkbcommon keysym type (xkb_keysym_t) and values (XKB_KEY_...) for both xkbcommon and traditional X11. - To facilitate the Dom |code| to be used, it removes all the code which was used to derive character from the keycode. To introduce XKB support in X11. - XKB related files are moved out of Ozone directory to ui/events/keycodes and now applies to both Ozone and X11. - Due to this move, layout_util is removed and xkb_keyboard_code_conversion functionality is moved to ui/events/keycode. - To derive meaning for X11 events updates returns a dom |key| and character from an XEvent. - Return the dom |key| determined by the XKB layout result (keysym, character) and character from an XEvent Originally based on Kevin's CLs. R=kpschoedel, Wez BUG=444048

Patch Set 1 #

Patch Set 2 : Compilation fix #

Patch Set 3 : Added missing VKEY in windows for brightness and power #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1253 lines, -832 lines) Patch
M content/renderer/render_view_browsertest.cc View 1 2 3 3 chunks +7 lines, -6 lines 0 comments Download
M ui/base/accelerators/accelerator.cc View 1 chunk +2 lines, -1 line 0 comments Download
M ui/events/BUILD.gn View 1 2 3 1 chunk +7 lines, -0 lines 0 comments Download
M ui/events/event.cc View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M ui/events/events.gyp View 1 2 3 1 chunk +7 lines, -0 lines 0 comments Download
M ui/events/keycodes/keyboard_code_conversion.h View 1 2 3 3 chunks +2 lines, -3 lines 0 comments Download
M ui/events/keycodes/keyboard_code_conversion.cc View 1 2 3 2 chunks +647 lines, -220 lines 0 comments Download
M ui/events/keycodes/keyboard_code_conversion_x.h View 3 chunks +7 lines, -0 lines 0 comments Download
M ui/events/keycodes/keyboard_code_conversion_x.cc View 3 chunks +11 lines, -2 lines 0 comments Download
A + ui/events/keycodes/keyboard_code_conversion_xkb.h View 1 2 chunks +6 lines, -7 lines 0 comments Download
A + ui/events/keycodes/keyboard_code_conversion_xkb.cc View 1 2 3 2 chunks +10 lines, -3 lines 0 comments Download
M ui/events/keycodes/keyboard_codes_win.h View 1 2 1 chunk +5 lines, -0 lines 0 comments Download
A ui/events/keycodes/xkb_keysym.h View 1 chunk +533 lines, -0 lines 0 comments Download
M ui/events/ozone/BUILD.gn View 1 2 3 2 chunks +0 lines, -4 lines 0 comments Download
M ui/events/ozone/evdev/keyboard_evdev.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M ui/events/ozone/events_ozone.gyp View 1 2 3 2 chunks +0 lines, -4 lines 0 comments Download
D ui/events/ozone/layout/layout_util.h View 1 2 3 1 chunk +0 lines, -24 lines 0 comments Download
D ui/events/ozone/layout/layout_util.cc View 1 2 3 1 chunk +0 lines, -49 lines 0 comments Download
M ui/events/ozone/layout/stub/stub_keyboard_layout_engine.cc View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
D ui/events/ozone/layout/xkb/xkb_keyboard_code_conversion.h View 1 chunk +0 lines, -32 lines 0 comments Download
D ui/events/ozone/layout/xkb/xkb_keyboard_code_conversion.cc View 1 2 3 1 chunk +0 lines, -453 lines 0 comments Download
M ui/events/ozone/layout/xkb/xkb_keyboard_layout_engine.cc View 1 2 3 4 chunks +4 lines, -20 lines 0 comments Download
M ui/events/test/event_generator.cc View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download
M ui/views/controls/menu/menu_event_dispatcher_linux.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (0 generated)
Habib Virji
It is based on the Kevin's patches. https://codereview.chromium.org/939703002/ https://codereview.chromium.org/940553002/ https://codereview.chromium.org/841263005/
5 years, 10 months ago (2015-02-25 15:08:51 UTC) #1
Habib Virji
@kevin/wez: are these changes okay?
5 years, 9 months ago (2015-03-03 17:24:20 UTC) #2
Wez
On 2015/03/03 17:24:20, Habib Virji wrote: > @kevin/wez: are these changes okay? Hi Habib, apologies ...
5 years, 9 months ago (2015-03-06 20:17:07 UTC) #3
Wez
On 2015/03/06 20:17:07, Wez wrote: > On 2015/03/03 17:24:20, Habib Virji wrote: > > @kevin/wez: ...
5 years, 9 months ago (2015-03-06 20:20:56 UTC) #4
Habib Virji
Thanks for having a look. I have the CL with high level description.
5 years, 9 months ago (2015-03-09 14:25:29 UTC) #5
Habib Virji
@Wez, kevin: Can you please suggest how to proceed on this CL?
5 years, 8 months ago (2015-04-20 14:19:55 UTC) #6
kpschoedel
On 2015/04/20 14:19:55, Habib Virji wrote: > @Wez, kevin: Can you please suggest how to ...
5 years, 8 months ago (2015-04-20 17:07:03 UTC) #7
Habib Virji
@Kevin: I reckon you have already pushed most of the changes in this patch and ...
5 years, 7 months ago (2015-04-30 13:27:38 UTC) #8
kpschoedel
On 2015/04/30 13:27:38, Habib Virji wrote: > @Kevin: I reckon you have already pushed most ...
5 years, 7 months ago (2015-04-30 13:59:06 UTC) #9
Habib Virji
Is this change correct from that respect: https://codereview.chromium.org/929053004/patch/40001/50005. Does it need to use GetDomKey to ...
5 years, 7 months ago (2015-04-30 14:01:11 UTC) #10
Habib Virji
Is this change correct from that respect: https://codereview.chromium.org/929053004/patch/40001/50005. Does it need to use GetDomKey to ...
5 years, 7 months ago (2015-04-30 14:01:13 UTC) #11
kpschoedel
On 2015/04/30 14:01:13, Habib Virji wrote: > Is this change correct from that respect: > ...
5 years, 7 months ago (2015-04-30 14:14:08 UTC) #12
Wez
Was this CL supposed to be closed, Habib?
5 years, 7 months ago (2015-05-06 01:33:18 UTC) #13
Habib Virji
5 years, 7 months ago (2015-05-06 15:34:46 UTC) #14
Message was sent while issue was closed.
On 2015/05/06 01:33:18, Wez wrote:
> Was this CL supposed to be closed, Habib?

Not sure actually, this patch was based on the Kevin patch to support DomKey on
X11. I have seen he has been pushing some of the changes in this patch and so i
have closed my patch. The main aim of this patch was similar to
https://codereview.chromium.org/1103263004, if this lands then DomKey should
work in X11.

Powered by Google App Engine
This is Rietveld 408576698