ui/events/event.cc - Issue 954943003: [KeyboardEvent] Use DOM |code| rather than Windows-based key code

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/events/event.cc

Issue 954943003: [KeyboardEvent] Use DOM |code| rather than Windows-based key code (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ui/events/event.cc

diff --git a/ui/events/event.cc b/ui/events/event.cc

index 4649e24db9f8722b8bad8d3a7aeeed8acaf9540d..76a081230f74a47f2bd7494c5c7654e06f5c60cb 100644

--- a/ui/events/event.cc

+++ b/ui/events/event.cc

@@ -808,6 +808,7 @@ void KeyEvent::ApplyLayout() const {

// characters in order to use it for shortcut keys. GetCharacterFromKeyCode

// returns 'a' for VKEY_A even if the key is actually bound to 'à' in X11.

// GetCharacterFromXEvent returns 'à' in that case.

if (!IsControlDown() && native_event()) {

character_ = GetCharacterFromXEvent(native_event());

// TODO(kpschoedel): set key_ field for X11.

« no previous file with comments | « ui/events/BUILD.gn ('k') | ui/events/events.gyp » ('j') | no next file with comments »