Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 953723003: Guest mode doesn't show the Bookmarks item in Wrench Menu. (Closed)

Created:
5 years, 10 months ago by Mike Lerman
Modified:
5 years, 9 months ago
Reviewers:
msw
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Guest mode doesn't show the Bookmarks item in Wrench Menu. BUG=436834 TEST=In guest mode (across browsers), Bookmarks doesn't show in the wrench menu. Committed: https://crrev.com/e5176cd6d8f377e603ed18705cea65f38f4e1fc5 Cr-Commit-Position: refs/heads/master@{#318133}

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Rebase #

Patch Set 4 : Browser test. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -3 lines) Patch
M chrome/browser/profiles/profile_window_browsertest.cc View 1 2 3 4 chunks +23 lines, -0 lines 0 comments Download
M chrome/browser/ui/toolbar/wrench_menu_model.cc View 1 1 chunk +5 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
Mike Lerman
Hi Mike, Small CL for you to review. Thanks! Mike
5 years, 10 months ago (2015-02-25 13:35:34 UTC) #2
msw
The change itself looks good, but can you add a unit test?
5 years, 9 months ago (2015-02-25 15:37:14 UTC) #3
Mike Lerman
Tada! Please review the browser test. Thanks!
5 years, 9 months ago (2015-02-25 20:16:27 UTC) #4
msw
lgtm!
5 years, 9 months ago (2015-02-25 20:39:31 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/953723003/60001
5 years, 9 months ago (2015-02-25 20:41:36 UTC) #7
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 9 months ago (2015-02-25 22:48:06 UTC) #8
commit-bot: I haz the power
5 years, 9 months ago (2015-02-25 22:49:37 UTC) #9
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/e5176cd6d8f377e603ed18705cea65f38f4e1fc5
Cr-Commit-Position: refs/heads/master@{#318133}

Powered by Google App Engine
This is Rietveld 408576698