chrome/browser/ui/toolbar/wrench_menu_model.cc - Issue 953723003: Guest mode doesn't show the Bookmarks item in Wrench Menu.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/toolbar/wrench_menu_model.cc

Issue 953723003: Guest mode doesn't show the Bookmarks item in Wrench Menu. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Browser test. Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/toolbar/wrench_menu_model.cc

diff --git a/chrome/browser/ui/toolbar/wrench_menu_model.cc b/chrome/browser/ui/toolbar/wrench_menu_model.cc

index 4f5087cdcb9523afe00ddea868fb7f07c1b0331b..ad3717f77a527f3784655e79eb19dc5dbfda5d5b 100644

--- a/chrome/browser/ui/toolbar/wrench_menu_model.cc

+++ b/chrome/browser/ui/toolbar/wrench_menu_model.cc

@@ -845,9 +845,11 @@ void WrenchMenuModel::Build() {

if (ShouldShowNewIncognitoWindowMenuItem())

AddItemWithStringId(IDC_NEW_INCOGNITO_WINDOW, IDS_NEW_INCOGNITO_WINDOW);

- bookmark_sub_menu_model_.reset(new BookmarkSubMenuModel(this, browser_));

- AddSubMenuWithStringId(IDC_BOOKMARKS_MENU, IDS_BOOKMARKS_MENU,

- bookmark_sub_menu_model_.get());

+ if (!browser_->profile()->IsGuestSession()) {

+ bookmark_sub_menu_model_.reset(new BookmarkSubMenuModel(this, browser_));

+ AddSubMenuWithStringId(IDC_BOOKMARKS_MENU, IDS_BOOKMARKS_MENU,

+ bookmark_sub_menu_model_.get());

+ }

if (!browser_->profile()->IsOffTheRecord()) {

recent_tabs_sub_menu_model_.reset(new RecentTabsSubMenuModel(provider_,

« no previous file with comments | « chrome/browser/profiles/profile_window_browsertest.cc ('k') | no next file » | no next file with comments »