Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1994)

Unified Diff: chrome/browser/profiles/profile_window_browsertest.cc

Issue 953723003: Guest mode doesn't show the Bookmarks item in Wrench Menu. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Browser test. Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/ui/toolbar/wrench_menu_model.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/profiles/profile_window_browsertest.cc
diff --git a/chrome/browser/profiles/profile_window_browsertest.cc b/chrome/browser/profiles/profile_window_browsertest.cc
index 9522f51b69f6364827d3133cfd3a0cfc41e9d54e..e040b2b54ba57efa4c6018a408f88d1444ee5e83 100644
--- a/chrome/browser/profiles/profile_window_browsertest.cc
+++ b/chrome/browser/profiles/profile_window_browsertest.cc
@@ -6,6 +6,7 @@
#include "base/command_line.h"
#include "base/strings/utf_string_conversions.h"
+#include "chrome/app/chrome_command_ids.h"
#include "chrome/browser/browser_process.h"
#include "chrome/browser/chrome_notification_types.h"
#include "chrome/browser/history/history_service.h"
@@ -16,6 +17,7 @@
#include "chrome/browser/ui/browser.h"
#include "chrome/browser/ui/browser_finder.h"
#include "chrome/browser/ui/browser_list.h"
+#include "chrome/browser/ui/toolbar/wrench_menu_model.h"
#include "chrome/test/base/in_process_browser_test.h"
#include "chrome/test/base/ui_test_utils.h"
#include "components/history/core/browser/history_db_task.h"
@@ -68,6 +70,15 @@ void WaitForHistoryBackendToRun(Profile* profile) {
content::RunMessageLoop();
}
+class EmptyAcceleratorHandler : public ui::AcceleratorProvider {
+ public:
+ // Don't handle accelerators.
+ bool GetAcceleratorForCommandId(int command_id,
+ ui::Accelerator* accelerator) override {
+ return false;
+ }
+};
+
} // namespace
class ProfileWindowBrowserTest : public InProcessBrowserTest {
@@ -188,4 +199,16 @@ IN_PROC_BROWSER_TEST_F(ProfileWindowBrowserTest, GuestCannotSignin) {
ASSERT_FALSE(signin_manager);
}
+IN_PROC_BROWSER_TEST_F(ProfileWindowBrowserTest, GuestWrenchLacksBookmarks) {
+ EmptyAcceleratorHandler accelerator_handler;
+ // Verify the normal browser has a bookmark menu.
+ WrenchMenuModel model_normal_profile(&accelerator_handler, browser());
+ EXPECT_NE(-1, model_normal_profile.GetIndexOfCommandId(IDC_BOOKMARKS_MENU));
+
+ // Guest browser has no bookmark menu.
+ Browser* guest_browser = OpenGuestBrowser();
+ WrenchMenuModel model_guest_profile(&accelerator_handler, guest_browser);
+ EXPECT_EQ(-1, model_guest_profile.GetIndexOfCommandId(IDC_BOOKMARKS_MENU));
+}
+
#endif // !defined(OS_CHROMEOS) && !defined(OS_ANDROID) && !defined(OS_IOS)
« no previous file with comments | « no previous file | chrome/browser/ui/toolbar/wrench_menu_model.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698