http_server: accept full NetAddress in CreateHttpServer.

http_server: accept full NetAddress in CreateHttpServer.

This patch allows to specify a full NetAddress on which the server is to
be set up.

This is needed to decide between running the server on externally
visible address (like http_handler would like) and localhost (like skydb
would like).

No change in behavior of existing clients in the Mojo repo should occur.
A follow-up patch will switch some of the clients from 0.0.0.0 to
localhost.

BUG=460908
R=qsr@chromium.org

Committed: https://chromium.googlesource.com/external/mojo/+/8d249d207d0cabd42a7b68bf44b1cdc77bec2d45

[ppi, 2015-02-23 16:32:09]

ppi@chromium.org changed reviewers:
+ qsr@chromium.org

[ppi, 2015-02-23 16:32:20]

Hi Ben,

ptal.

[qsr, 2015-02-23 17:14:01]

https://codereview.chromium.org/953513002/diff/1/services/http_server/http_se...
File services/http_server/http_server_factory_impl.cc (right):

https://codereview.chromium.org/953513002/diff/1/services/http_server/http_se...
services/http_server/http_server_factory_impl.cc:32: mojo::NetAddressPtr
requested_address) {
Take a mojo::NetAddress* instead, so you do not need to clone. Here and mostly
everywhere.

https://codereview.chromium.org/953513002/diff/1/services/http_server/http_se...
services/http_server/http_server_factory_impl.cc:66: mojo::NetAddressPtr
local_address) {
local_address is optional, what about making it 0.0.0.0 when null?

[ppi, 2015-02-24 10:59:55]

Thanks, Ben. Ptal.

https://codereview.chromium.org/953513002/diff/1/services/http_server/http_se...
File services/http_server/http_server_factory_impl.cc (right):

https://codereview.chromium.org/953513002/diff/1/services/http_server/http_se...
services/http_server/http_server_factory_impl.cc:32: mojo::NetAddressPtr
requested_address) {
On 2015/02/23 17:14:01, qsr wrote:
> Take a mojo::NetAddress* instead, so you do not need to clone. Here and mostly
> everywhere.

Done.

https://codereview.chromium.org/953513002/diff/1/services/http_server/http_se...
services/http_server/http_server_factory_impl.cc:66: mojo::NetAddressPtr
local_address) {
On 2015/02/23 17:14:01, qsr wrote:
> local_address is optional, what about making it 0.0.0.0 when null?

Done.

[qsr, 2015-02-24 15:50:28]

lgtm

[ppi, 2015-02-24 16:33:47]

Committed patchset #3 (id:40001) manually as
8d249d207d0cabd42a7b68bf44b1cdc77bec2d45 (presubmit successful).