Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2695)

Unified Diff: services/http_server/http_server_impl.h

Issue 953513002: http_server: accept full NetAddress in CreateHttpServer. (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: Address Ben's comments. Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « services/http_server/http_server_factory_impl.cc ('k') | services/http_server/http_server_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: services/http_server/http_server_impl.h
diff --git a/services/http_server/http_server_impl.h b/services/http_server/http_server_impl.h
index 4990758ee9ce93412ef360dfc23a4a108d54704f..f4d211eb3fab0a5399a2a96c351f5c1eec034e29 100644
--- a/services/http_server/http_server_impl.h
+++ b/services/http_server/http_server_impl.h
@@ -8,6 +8,7 @@
#include "mojo/common/weak_binding_set.h"
#include "mojo/public/cpp/bindings/interface_request.h"
#include "mojo/public/cpp/bindings/strong_binding.h"
+#include "mojo/services/network/public/interfaces/net_address.mojom.h"
#include "mojo/services/network/public/interfaces/network_service.mojom.h"
#include "services/http_server/public/http_request.mojom.h"
#include "services/http_server/public/http_response.mojom.h"
@@ -27,7 +28,7 @@ class HttpServerImpl : public HttpServer, public mojo::ErrorHandler {
public:
HttpServerImpl(mojo::ApplicationImpl* app,
HttpServerFactoryImpl* factory,
- uint16_t port);
+ mojo::NetAddressPtr requested_local_address);
~HttpServerImpl() override;
void AddBinding(mojo::InterfaceRequest<HttpServer> request);
@@ -71,7 +72,7 @@ class HttpServerImpl : public HttpServer, public mojo::ErrorHandler {
HttpServerFactoryImpl* factory_;
- uint16_t requested_port_;
+ mojo::NetAddressPtr requested_local_address_;
uint16_t assigned_port_;
std::vector<GetPortCallback> pending_get_port_callbacks_;
« no previous file with comments | « services/http_server/http_server_factory_impl.cc ('k') | services/http_server/http_server_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698