Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(329)

Unified Diff: services/http_server/http_server_apptest.cc

Issue 953513002: http_server: accept full NetAddress in CreateHttpServer. (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: Address Ben's comments. Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « examples/http_handler/http_handler.cc ('k') | services/http_server/http_server_factory_impl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: services/http_server/http_server_apptest.cc
diff --git a/services/http_server/http_server_apptest.cc b/services/http_server/http_server_apptest.cc
index ba7ade5b1f3d8291f96dbfcbb627be6fbb38c93f..2971d67589aa9c2a5ca0f3f7bc446f801d55425d 100644
--- a/services/http_server/http_server_apptest.cc
+++ b/services/http_server/http_server_apptest.cc
@@ -9,6 +9,7 @@
#include "mojo/public/cpp/application/application_impl.h"
#include "mojo/public/cpp/application/application_test_base.h"
#include "mojo/public/cpp/system/macros.h"
+#include "mojo/services/network/public/interfaces/net_address.mojom.h"
#include "mojo/services/network/public/interfaces/network_service.mojom.h"
#include "mojo/services/network/public/interfaces/url_loader.mojom.h"
#include "services/http_server/public/http_server.mojom.h"
@@ -129,7 +130,8 @@ void CheckServerResponse(mojo::URLResponsePtr response) {
// GetHandler.
TEST_F(HttpServerApplicationTest, ServerResponse) {
http_server::HttpServerPtr http_server;
- http_server_factory_->CreateHttpServer(GetProxy(&http_server).Pass(), 0u);
+ http_server_factory_->CreateHttpServer(GetProxy(&http_server).Pass(),
+ nullptr);
uint16_t assigned_port;
http_server->GetPort([&assigned_port](uint16_t p) { assigned_port = p; });
@@ -158,7 +160,8 @@ TEST_F(HttpServerApplicationTest, ServerResponse) {
// example PostHandler.
TEST_F(HttpServerApplicationTest, PostData) {
http_server::HttpServerPtr http_server;
- http_server_factory_->CreateHttpServer(GetProxy(&http_server).Pass(), 0u);
+ http_server_factory_->CreateHttpServer(GetProxy(&http_server).Pass(),
+ nullptr);
uint16_t assigned_port;
http_server->GetPort([&assigned_port](uint16_t p) { assigned_port = p; });
« no previous file with comments | « examples/http_handler/http_handler.cc ('k') | services/http_server/http_server_factory_impl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698