Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Issue 953383002: fuzzer fixes (Closed)

Created:
5 years, 10 months ago by caryclark
Modified:
5 years, 10 months ago
Reviewers:
reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

fuzzer fixes Fix path bugs exposed by the path fuzzer. Changes to existing gm and samplecode files defer their calls to construct SkPath objects until the first draw instead of at test initialization. Add an experimental call to SkPath to validate the internal SkPathRef. Fix SkPath::addPoly to set the last moveto after adding a close verb. Fix stroke to handle failures when computing the unit normal. Add a unit test for the unit normal failure. R=reed@google.com Committed: https://skia.googlesource.com/skia/+/63c684a8a609d39da11b4a656223cebf52ca85dc

Patch Set 1 #

Patch Set 2 : fix release build #

Total comments: 1

Patch Set 3 : update override; add onOnceBeforeDraw to sample app #

Patch Set 4 : fix up width and height in initializer #

Unified diffs Side-by-side diffs Delta from patch set Stats (+765 lines, -58 lines) Patch
M gm/bitmapshader.cpp View 1 2 1 chunk +2 lines, -3 lines 0 comments Download
M gm/circularclips.cpp View 1 2 2 chunks +2 lines, -3 lines 0 comments Download
M gm/complexclip2.cpp View 1 2 3 4 chunks +15 lines, -8 lines 0 comments Download
M gm/picture.cpp View 1 2 1 chunk +7 lines, -1 line 0 comments Download
M gm/pictureshader.cpp View 1 2 1 chunk +6 lines, -4 lines 0 comments Download
M gm/shadows.cpp View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M gm/simpleaaclip.cpp View 1 2 2 chunks +3 lines, -1 line 0 comments Download
M gm/strokes.cpp View 1 2 2 chunks +2 lines, -3 lines 0 comments Download
M gyp/SampleApp.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M include/core/SkPath.h View 1 chunk +1 line, -0 lines 0 comments Download
M samplecode/SampleApp.cpp View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M samplecode/SampleCode.h View 1 2 3 chunks +3 lines, -1 line 0 comments Download
M samplecode/SamplePathEffects.cpp View 1 2 2 chunks +4 lines, -1 line 0 comments Download
A samplecode/SamplePathFuzz.cpp View 1 1 chunk +651 lines, -0 lines 0 comments Download
M samplecode/SampleStrokePath.cpp View 1 2 2 chunks +2 lines, -3 lines 0 comments Download
M samplecode/SampleTextOnPath.cpp View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M src/core/SkPath.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M src/core/SkStroke.cpp View 8 chunks +27 lines, -26 lines 0 comments Download
M tests/StrokeTest.cpp View 2 chunks +30 lines, -0 lines 0 comments Download

Messages

Total messages: 18 (7 generated)
caryclark
5 years, 10 months ago (2015-02-25 15:45:42 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/953383002/1
5 years, 10 months ago (2015-02-25 15:46:53 UTC) #3
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 10 months ago (2015-02-25 15:46:54 UTC) #4
commit-bot: I haz the power
Presubmit check for 953383002-1 failed and returned exit status 1. Running presubmit commit checks ...
5 years, 10 months ago (2015-02-25 15:47:01 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/953383002/20001
5 years, 10 months ago (2015-02-25 16:08:03 UTC) #8
reed1
https://codereview.chromium.org/953383002/diff/20001/gm/bitmapshader.cpp File gm/bitmapshader.cpp (right): https://codereview.chromium.org/953383002/diff/20001/gm/bitmapshader.cpp#newcode46 gm/bitmapshader.cpp:46: virtual void onOnceBeforeDraw() { new style for overrides: void ...
5 years, 10 months ago (2015-02-25 16:08:16 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: Test-Ubuntu13.10-GCE-NoGPU-x86_64-Release-Shared-Trybot on client.skia (JOB_FAILED, http://build.chromium.org/p/client.skia/builders/Test-Ubuntu13.10-GCE-NoGPU-x86_64-Release-Shared-Trybot/builds/2295)
5 years, 10 months ago (2015-02-25 16:13:35 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/953383002/40001
5 years, 10 months ago (2015-02-25 16:26:33 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/953383002/60001
5 years, 10 months ago (2015-02-25 16:54:44 UTC) #16
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 10 months ago (2015-02-25 17:04:05 UTC) #17
commit-bot: I haz the power
5 years, 10 months ago (2015-02-25 17:04:10 UTC) #18
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://skia.googlesource.com/skia/+/63c684a8a609d39da11b4a656223cebf52ca85dc

Powered by Google App Engine
This is Rietveld 408576698