Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(233)

Issue 952953002: Subzero: Improve class definition hygiene. (Closed)

Created:
5 years, 10 months ago by Jim Stichnoth
Modified:
5 years, 10 months ago
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Subzero: Improve class definition hygiene. Delete zero-argument ctor where possible. Delete default copy ctor and default assignment operator where possible (some were missed in the past). (The above are not done to the cross tests because we aren't yet building them with C++11.) Declare single-argument ctor as "explicit". BUG= none R=jfb@chromium.org Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=c6ead20cc2e9ecb0ca45b650ce911ef565d88f6e

Patch Set 1 #

Patch Set 2 : Fix cross tests. #

Total comments: 2

Patch Set 3 : Fix typo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+191 lines, -35 lines) Patch
M crosstest/vectors.h View 1 1 chunk +1 line, -1 line 0 comments Download
M src/IceAPInt.h View 1 2 2 chunks +5 lines, -1 line 0 comments Download
M src/IceCfg.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/IceCfgNode.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/IceConditionCodesX8632.h View 1 chunk +4 lines, -0 lines 0 comments Download
M src/IceConverter.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/IceConverter.cpp View 3 chunks +6 lines, -3 lines 0 comments Download
M src/IceELFObjectWriter.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/IceELFSection.h View 6 chunks +9 lines, -0 lines 0 comments Download
M src/IceELFStreamer.h View 1 chunk +4 lines, -0 lines 0 comments Download
M src/IceFixups.h View 1 chunk +4 lines, -0 lines 0 comments Download
M src/IceGlobalContext.h View 3 chunks +6 lines, -0 lines 0 comments Download
M src/IceGlobalInits.h View 2 chunks +2 lines, -0 lines 0 comments Download
M src/IceInst.h View 28 chunks +28 lines, -2 lines 0 comments Download
M src/IceInstX8632.h View 46 chunks +47 lines, -2 lines 0 comments Download
M src/IceLiveness.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/IceOperand.h View 13 chunks +18 lines, -8 lines 0 comments Download
M src/IceRNG.h View 3 chunks +5 lines, -2 lines 0 comments Download
M src/IceRegAlloc.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/IceRegAlloc.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M src/IceTargetLowering.h View 3 chunks +3 lines, -2 lines 0 comments Download
M src/IceTargetLoweringX8632.h View 3 chunks +3 lines, -2 lines 0 comments Download
M src/IceTargetLoweringX8632.cpp View 3 chunks +3 lines, -4 lines 0 comments Download
M src/IceTimerTree.h View 2 chunks +2 lines, -1 line 0 comments Download
M src/IceTranslator.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/IceTypeConverter.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/IceUtils.h View 1 chunk +4 lines, -0 lines 0 comments Download
M src/PNaClTranslator.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/PNaClTranslator.cpp View 12 chunks +21 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Jim Stichnoth
5 years, 10 months ago (2015-02-24 15:54:29 UTC) #2
JF
=͟͟͞͞ʕ•̫͡•ʔ =͟͟͞͞ʕ•̫͡•ʔ =͟͟͞͞ʕ•̫͡•ʔ =͟͟͞͞ʕ•̫͡•ʔ =͟͟͞͞ʕ•̫͡•ʔ lgtm https://codereview.chromium.org/952953002/diff/20001/src/IceAPInt.h File src/IceAPInt.h (right): https://codereview.chromium.org/952953002/diff/20001/src/IceAPInt.h#newcode12 src/IceAPInt.h:12: /// values, and ...
5 years, 10 months ago (2015-02-24 16:57:05 UTC) #3
Jim Stichnoth
https://codereview.chromium.org/952953002/diff/20001/src/IceAPInt.h File src/IceAPInt.h (right): https://codereview.chromium.org/952953002/diff/20001/src/IceAPInt.h#newcode12 src/IceAPInt.h:12: /// values, and thier conversion to variable bit sized ...
5 years, 10 months ago (2015-02-24 17:27:11 UTC) #4
Jim Stichnoth
5 years, 10 months ago (2015-02-24 17:30:35 UTC) #5
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
c6ead20cc2e9ecb0ca45b650ce911ef565d88f6e (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698