src/PNaClTranslator.h - Issue 952953002: Subzero: Improve class definition hygiene.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/PNaClTranslator.h

Issue 952953002: Subzero: Improve class definition hygiene. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master

Patch Set: Fix typo Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/PNaClTranslator.h

diff --git a/src/PNaClTranslator.h b/src/PNaClTranslator.h

index 1bd4d5b97c175275c01b0ff6ab9747a304a7b841..9162d59ab1993027598c6073510bf0ab0f88ab05 100644

--- a/src/PNaClTranslator.h

+++ b/src/PNaClTranslator.h

@@ -26,11 +26,12 @@ class MemoryBuffer;

namespace Ice {

class PNaClTranslator : public Translator {

+ PNaClTranslator() = delete;

PNaClTranslator(const PNaClTranslator &) = delete;

PNaClTranslator &operator=(const PNaClTranslator &) = delete;

public:

- PNaClTranslator(GlobalContext *Ctx) : Translator(Ctx) {}

+ explicit PNaClTranslator(GlobalContext *Ctx) : Translator(Ctx) {}

// Reads the PNaCl bitcode file and translates to ICE, which is then

// converted to machine code. Sets ErrorStatus to 1 if any errors

« no previous file with comments | « src/IceUtils.h ('k') | src/PNaClTranslator.cpp » ('j') | no next file with comments »