Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(699)

Unified Diff: src/IceELFSection.h

Issue 952953002: Subzero: Improve class definition hygiene. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Patch Set: Fix typo Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/IceELFObjectWriter.h ('k') | src/IceELFStreamer.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/IceELFSection.h
diff --git a/src/IceELFSection.h b/src/IceELFSection.h
index 535d1530b06f44f323151417d8aa6a16c3476f50..0bfccca650a78b488bee7ce427e4a1a0a18d83e8 100644
--- a/src/IceELFSection.h
+++ b/src/IceELFSection.h
@@ -28,6 +28,7 @@ class ELFStringTableSection;
// Base representation of an ELF section.
class ELFSection {
+ ELFSection() = delete;
ELFSection(const ELFSection &) = delete;
ELFSection &operator=(const ELFSection &) = delete;
@@ -97,6 +98,7 @@ protected:
// Models text/code sections. Code is written out incrementally and the
// size of the section is then updated incrementally.
class ELFTextSection : public ELFSection {
+ ELFTextSection() = delete;
ELFTextSection(const ELFTextSection &) = delete;
ELFTextSection &operator=(const ELFTextSection &) = delete;
@@ -110,6 +112,7 @@ public:
// size of the section is then updated incrementally.
// Some rodata sections may have fixed entsize and duplicates may be mergeable.
class ELFDataSection : public ELFSection {
+ ELFDataSection() = delete;
ELFDataSection(const ELFDataSection &) = delete;
ELFDataSection &operator=(const ELFDataSection &) = delete;
@@ -155,6 +158,10 @@ struct ELFSym {
// Models a symbol table. Symbols may be added up until updateIndices is
// called. At that point the indices of each symbol will be finalized.
class ELFSymbolTableSection : public ELFSection {
+ ELFSymbolTableSection() = delete;
+ ELFSymbolTableSection(const ELFSymbolTableSection &) = delete;
+ ELFSymbolTableSection &operator=(const ELFSymbolTableSection &) = delete;
+
public:
using ELFSection::ELFSection;
@@ -199,6 +206,7 @@ private:
// Models a relocation section.
class ELFRelocationSection : public ELFSection {
+ ELFRelocationSection() = delete;
ELFRelocationSection(const ELFRelocationSection &) = delete;
ELFRelocationSection &operator=(const ELFRelocationSection &) = delete;
@@ -237,6 +245,7 @@ private:
// can be discovered and used to fill out section headers and symbol
// table entries.
class ELFStringTableSection : public ELFSection {
+ ELFStringTableSection() = delete;
ELFStringTableSection(const ELFStringTableSection &) = delete;
ELFStringTableSection &operator=(const ELFStringTableSection &) = delete;
« no previous file with comments | « src/IceELFObjectWriter.h ('k') | src/IceELFStreamer.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698