Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(856)

Issue 952443004: Update gyp files to reflect moved and removed header files in content/ (Closed)

Created:
5 years, 10 months ago by Daniel Bratell
Modified:
5 years, 10 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update gyp files to reflect moved and removed header files in content/ Fixes warnings in the msvs-gyp generator. This is a followup to https://codereview.chromium.org/615893003 (gesture_event_type_list.h, popup_item_type_list.h, result_codes_list.h and top_controls_state_list.h) https://codereview.chromium.org/861373002 (navigator_connect_service.h and navigator_connect_servive_factory.h) https://codereview.chromium.org/865413002 (layer_tree_build_helper.h) https://codereview.chromium.org/774573003 (platform_notification_service.h) R=jam@chromium.org,avi@chromium.org,mek@chromium.org,dtrainor@chromium.org,changwan@chromium.org,peter@chromium.org BUG=459058, 405532, 351558, 426458, 451313, 439950 Committed: https://crrev.com/88db1a01502634619859cc428151bc571d6eebac Cr-Commit-Position: refs/heads/master@{#317617}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -8 lines) Patch
M content/content_browser.gypi View 5 chunks +1 line, -5 lines 1 comment Download
M content/content_common.gypi View 3 chunks +0 lines, -3 lines 0 comments Download

Messages

Total messages: 10 (1 generated)
Daniel Bratell
5 years, 10 months ago (2015-02-23 14:05:26 UTC) #1
Peter Beverloo
lgtm, thank you Daniel! https://codereview.chromium.org/952443004/diff/1/content/content_browser.gypi File content/content_browser.gypi (left): https://codereview.chromium.org/952443004/diff/1/content/content_browser.gypi#oldcode365 content/content_browser.gypi:365: 'browser/android/popup_item_type_list.h', It looks like the ...
5 years, 10 months ago (2015-02-23 14:20:31 UTC) #2
Avi (use Gerrit)
Daniel: You only need as many reviewers
5 years, 10 months ago (2015-02-23 16:39:31 UTC) #3
jam
lgtm
5 years, 10 months ago (2015-02-23 16:53:06 UTC) #4
Daniel Bratell
On 2015/02/23 16:39:31, Avi wrote: > Daniel: > > You only need as many reviewers ...
5 years, 10 months ago (2015-02-23 17:34:24 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/952443004/1
5 years, 10 months ago (2015-02-23 17:35:24 UTC) #7
David Trainor- moved to gerrit
delayed lgtm! :)
5 years, 10 months ago (2015-02-23 18:07:00 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-23 19:05:29 UTC) #9
commit-bot: I haz the power
5 years, 10 months ago (2015-02-23 19:06:17 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/88db1a01502634619859cc428151bc571d6eebac
Cr-Commit-Position: refs/heads/master@{#317617}

Powered by Google App Engine
This is Rietveld 408576698