Refactor navigator.connect code to make it more flexible.

Refactor navigator.connect code to make it more flexible.

This separates out all the service worker specific code from the generic
connection handling. As well as exposing some API in content/public so
code outside of content/ can handle connections.

This is the first step in making it possible to have chrome extensions,
or other code outside of content/ be the endpoint of a connection.

This doesn't change any functionality, it just moves code around.

BUG=426458
Committed: https://crrev.com/59114f60cc27b7ceefbb2d85a288b0dd1134df10
Cr-Commit-Position: refs/heads/master@{#313185}

[Marijn Kruisselbrink, 2015-01-22 21:30:58]

Patchset #3 (id:40001) has been deleted

[Marijn Kruisselbrink, 2015-01-22 21:31:04]

Patchset #2 (id:20001) has been deleted

[Marijn Kruisselbrink, 2015-01-22 21:31:10]

Patchset #1 (id:1) has been deleted

[Marijn Kruisselbrink, 2015-01-22 21:43:03]

Patchset #1 (id:60001) has been deleted

[Marijn Kruisselbrink, 2015-01-23 19:27:02]

Patchset #2 (id:100001) has been deleted

[Marijn Kruisselbrink, 2015-01-23 19:27:08]

Patchset #1 (id:80001) has been deleted

[Marijn Kruisselbrink, 2015-01-23 19:33:08]

mek@chromium.org changed reviewers:
+ scheib@chromium.org

[Marijn Kruisselbrink, 2015-01-23 19:33:09]

This patch turned out way larger than I hoped/expected... At least all it does
is move code around. If you think this is too big of a patch to review, I can of
course try to split it up more.

[scheib, 2015-01-23 22:03:58]

lgtm

https://codereview.chromium.org/861373002/diff/140001/content/browser/navigat...
File content/browser/navigator_connect/navigator_connect_context_impl.cc
(right):

https://codereview.chromium.org/861373002/diff/140001/content/browser/navigat...
content/browser/navigator_connect/navigator_connect_context_impl.cc:31: //
priority.
take priority as per comment at NavigatorConnectContext::AddFactory.

https://codereview.chromium.org/861373002/diff/140001/content/browser/navigat...
File content/browser/navigator_connect/navigator_connect_context_impl.h (right):

https://codereview.chromium.org/861373002/diff/140001/content/browser/navigat...
content/browser/navigator_connect/navigator_connect_context_impl.h:33: //
correct service factory and passes the connection request of to there.
of->off

https://codereview.chromium.org/861373002/diff/140001/content/browser/navigat...
File content/browser/navigator_connect/navigator_connect_dispatcher_host.cc
(right):

https://codereview.chromium.org/861373002/diff/140001/content/browser/navigat...
content/browser/navigator_connect/navigator_connect_dispatcher_host.cc:40:
static_cast<NavigatorConnectContextImpl*>(navigator_connect_context_.get())
static_cast... so... disliked. I don't think it's needed:

Create a StoragePartitionImpl::GetNavigatorConnectContextImpl() method.

Use it in render_process_host_impl.cc to pass Impl pointer to
NavigatorConnectDispatcherHost::NavigatorConnectDispatcherHost()

https://codereview.chromium.org/861373002/diff/140001/content/browser/navigat...
File
content/browser/navigator_connect/navigator_connect_service_worker_service_factory.h
(right):

https://codereview.chromium.org/861373002/diff/140001/content/browser/navigat...
content/browser/navigator_connect/navigator_connect_service_worker_service_factory.h:25:
class NavigatorConnectServiceWorkerServiceFactory
:D

https://codereview.chromium.org/861373002/diff/140001/content/public/browser/...
File content/public/browser/content_browser_client.h (right):

https://codereview.chromium.org/861373002/diff/140001/content/public/browser/...
content/public/browser/content_browser_client.h:593: // Allows to register
additional navigator.connect service factories available
"Allows to register " -> "Registers "

https://codereview.chromium.org/861373002/diff/140001/content/public/browser/...
File content/public/browser/navigator_connect_context.h (right):

https://codereview.chromium.org/861373002/diff/140001/content/public/browser/...
content/public/browser/navigator_connect_context.h:16: // The most recently
added factory that claims to handle a URL will be used to
Move the AddFactory doc to the method.

https://codereview.chromium.org/861373002/diff/140001/content/public/browser/...
File content/public/browser/navigator_connect_service.h (right):

https://codereview.chromium.org/861373002/diff/140001/content/public/browser/...
content/public/browser/navigator_connect_service.h:17: // instance of this class
when accepting a connection. All messages send to the
send->sent

[Marijn Kruisselbrink, 2015-01-26 21:34:27]

https://codereview.chromium.org/861373002/diff/140001/content/browser/navigat...
File content/browser/navigator_connect/navigator_connect_context_impl.cc
(right):

https://codereview.chromium.org/861373002/diff/140001/content/browser/navigat...
content/browser/navigator_connect/navigator_connect_context_impl.cc:31: //
priority.
On 2015/01/23 22:03:58, scheib wrote:
> take priority as per comment at NavigatorConnectContext::AddFactory.

Done.

https://codereview.chromium.org/861373002/diff/140001/content/browser/navigat...
File content/browser/navigator_connect/navigator_connect_context_impl.h (right):

https://codereview.chromium.org/861373002/diff/140001/content/browser/navigat...
content/browser/navigator_connect/navigator_connect_context_impl.h:33: //
correct service factory and passes the connection request of to there.
On 2015/01/23 22:03:58, scheib wrote:
> of->off

Done.

https://codereview.chromium.org/861373002/diff/140001/content/browser/navigat...
File content/browser/navigator_connect/navigator_connect_dispatcher_host.cc
(right):

https://codereview.chromium.org/861373002/diff/140001/content/browser/navigat...
content/browser/navigator_connect/navigator_connect_dispatcher_host.cc:40:
static_cast<NavigatorConnectContextImpl*>(navigator_connect_context_.get())
On 2015/01/23 22:03:58, scheib wrote:
> static_cast... so... disliked. I don't think it's needed:
> 
> Create a StoragePartitionImpl::GetNavigatorConnectContextImpl() method.
> 
> Use it in render_process_host_impl.cc to pass Impl pointer to
> NavigatorConnectDispatcherHost::NavigatorConnectDispatcherHost()

Done.

https://codereview.chromium.org/861373002/diff/140001/content/public/browser/...
File content/public/browser/content_browser_client.h (right):

https://codereview.chromium.org/861373002/diff/140001/content/public/browser/...
content/public/browser/content_browser_client.h:593: // Allows to register
additional navigator.connect service factories available
On 2015/01/23 22:03:58, scheib wrote:
> "Allows to register " -> "Registers "

Done.

https://codereview.chromium.org/861373002/diff/140001/content/public/browser/...
File content/public/browser/navigator_connect_context.h (right):

https://codereview.chromium.org/861373002/diff/140001/content/public/browser/...
content/public/browser/navigator_connect_context.h:16: // The most recently
added factory that claims to handle a URL will be used to
On 2015/01/23 22:03:58, scheib wrote:
> Move the AddFactory doc to the method.

Done.

https://codereview.chromium.org/861373002/diff/140001/content/public/browser/...
File content/public/browser/navigator_connect_service.h (right):

https://codereview.chromium.org/861373002/diff/140001/content/public/browser/...
content/public/browser/navigator_connect_service.h:17: // instance of this class
when accepting a connection. All messages send to the
On 2015/01/23 22:03:58, scheib wrote:
> send->sent

Done.

[Marijn Kruisselbrink, 2015-01-26 21:36:38]

mek@chromium.org changed reviewers:
+ avi@chromium.org

[Marijn Kruisselbrink, 2015-01-26 21:36:38]

+avi for content/ OWNERS review

[Avi (use Gerrit), 2015-01-27 00:03:36]

lgtm

https://codereview.chromium.org/861373002/diff/180001/content/browser/navigat...
File
content/browser/navigator_connect/navigator_connect_service_worker_service_factory.h
(right):

https://codereview.chromium.org/861373002/diff/180001/content/browser/navigat...
content/browser/navigator_connect/navigator_connect_service_worker_service_factory.h:6:
#define
CONTENT_BROWSER_NAVIGAOR_CONNECT_NAVIGATOR_CONNECT_SERVICE_WORKER_SERVICE_FACTORY_H_
Fix typo: NAVIGATOR

[Marijn Kruisselbrink, 2015-01-27 00:09:20]

mek@chromium.org changed reviewers:
+ tsepez@chromium.org

[Marijn Kruisselbrink, 2015-01-27 00:09:21]

+tsepez for IPC OWNERS review (the only IPC related change is renaming of a
struct)

https://codereview.chromium.org/861373002/diff/180001/content/browser/navigat...
File
content/browser/navigator_connect/navigator_connect_service_worker_service_factory.h
(right):

https://codereview.chromium.org/861373002/diff/180001/content/browser/navigat...
content/browser/navigator_connect/navigator_connect_service_worker_service_factory.h:6:
#define
CONTENT_BROWSER_NAVIGAOR_CONNECT_NAVIGATOR_CONNECT_SERVICE_WORKER_SERVICE_FACTORY_H_
On 2015/01/27 00:03:36, Avi wrote:
> Fix typo: NAVIGATOR

Done.

[Tom Sepez, 2015-01-27 01:00:23]

RS LGTM on renaming struct.

[Marijn Kruisselbrink, 2015-01-27 01:03:17]

The CQ bit was checked by mek@chromium.org

[commit-bot: I haz the power, 2015-01-27 01:04:32]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/861373002/200001

[commit-bot: I haz the power, 2015-01-27 01:14:38]

Committed patchset #5 (id:200001)

[commit-bot: I haz the power, 2015-01-27 01:15:40]

Patchset 5 (id:??) landed as
https://crrev.com/59114f60cc27b7ceefbb2d85a288b0dd1134df10
Cr-Commit-Position: refs/heads/master@{#313185}