Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 865413002: Remove unnecessary LayerTreeBuildHelper from ContentViewRenderView (Closed)

Created:
5 years, 11 months ago by Changwan Ryu
Modified:
5 years, 11 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove unnecessary LayerTreeBuildHelper from ContentViewRenderView (depends on downstream change: https://chrome-internal-review.googlesource.com/192999) BUG=451313 Committed: https://crrev.com/7e1ca93c15ffbd030e96f29f1e385ea3b0d678e8 Cr-Commit-Position: refs/heads/master@{#313043}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -80 lines) Patch
M content/browser/android/content_view_render_view.h View 2 chunks +0 lines, -3 lines 0 comments Download
M content/browser/android/content_view_render_view.cc View 1 4 chunks +3 lines, -36 lines 0 comments Download
M content/public/android/java/src/org/chromium/content/browser/ContentViewRenderView.java View 2 chunks +0 lines, -10 lines 0 comments Download
D content/public/browser/android/layer_tree_build_helper.h View 1 1 chunk +0 lines, -31 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
Changwan Ryu
5 years, 11 months ago (2015-01-23 06:28:54 UTC) #2
Ted C
lgtm
5 years, 11 months ago (2015-01-23 18:19:30 UTC) #3
David Trainor- moved to gerrit
lgtm
5 years, 11 months ago (2015-01-23 22:03:52 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/865413002/20001
5 years, 11 months ago (2015-01-26 02:34:49 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 11 months ago (2015-01-26 03:20:09 UTC) #7
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/7e1ca93c15ffbd030e96f29f1e385ea3b0d678e8 Cr-Commit-Position: refs/heads/master@{#313043}
5 years, 11 months ago (2015-01-26 03:21:11 UTC) #8
whywhat
5 years, 11 months ago (2015-01-26 11:14:53 UTC) #9
Message was sent while issue was closed. 
On 2015/01/26 03:21:11, I haz the power (commit-bot) wrote:
> Patchset 2 (id:??) landed as
> https://crrev.com/7e1ca93c15ffbd030e96f29f1e385ea3b0d678e8
> Cr-Commit-Position: refs/heads/master@{#313043}

FYI, the downstream change wasn't complete, clank doesn't build without
LayerTreeBuildHelper. I'll prepare a change to fix this.
See
https://uberchromegw.corp.google.com/i/clank.tot/builders/clang-clankium-tot-...
for an example of the compile failure.

Powered by Google App Engine
This is Rietveld 408576698