Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(199)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 952273006: Make the constructor of a LayoutRect from an IntRect explicit. (Closed)

Created:
5 years, 10 months ago by chrishtr
Modified:
5 years, 10 months ago
CC:
aandrey+blink_chromium.org, aboxhall, apavlov+blink_chromium.org, blink-layers+watch_chromium.org, blink-reviews, blink-reviews-dom_chromium.org, blink-reviews-html_chromium.org, blink-reviews-paint_chromium.org, blink-reviews-rendering, Rik, caseq+blink_chromium.org, danakj, devtools-reviews_chromium.org, dglazkov+blink, dmazzoni, Dominik Röttsches, dshwang, krit, eae+blinkwatch, ed+blinkwatch_opera.com, eustas+blink_chromium.org, f(malita), fs, gyuyoung.kim_webkit.org, jbroman, jchaffraix+rendering, je_julie(Not used), Justin Novosad, kouhei+svg_chromium.org, kozyatinskiy+blink_chromium.org, leviw+renderwatch, loislo+blink_chromium.org, lushnikov+blink_chromium.org, malch+blink_chromium.org, nektarios, pdr+svgwatchlist_chromium.org, pdr+renderingwatchlist_chromium.org, pdr+graphicswatchlist_chromium.org, pfeldman+blink_chromium.org, rwlbuis, Stephen Chennney, sergeyv+blink_chromium.org, sof, slimming-paint-reviews_chromium.org, yurys+blink_chromium.org, zoltan1
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Make the constructor of a LayoutRect from an IntRect explicit. BUG=461615 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=190957

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Total comments: 3

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+80 lines, -80 lines) Patch
M Source/core/dom/Document.cpp View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/dom/DocumentMarkerController.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/Node.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/frame/LocalFrame.cpp View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLCanvasElement.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/html/HTMLTextFormControlElementTest.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/core/inspector/InspectorOverlay.cpp View 1 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/layout/HitTestLocation.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/layout/HitTestLocation.cpp View 3 chunks +5 lines, -5 lines 0 comments Download
M Source/core/layout/Layer.cpp View 1 6 chunks +6 lines, -6 lines 0 comments Download
M Source/core/layout/LayerClipper.cpp View 5 chunks +7 lines, -7 lines 0 comments Download
M Source/core/layout/LayerScrollableArea.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/layout/LayoutBlock.cpp View 1 3 chunks +3 lines, -3 lines 0 comments Download
M Source/core/layout/LayoutBox.cpp View 1 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/layout/LayoutInline.cpp View 1 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/layout/LayoutTreeAsText.cpp View 1 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/layout/line/InlineFlowBox.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/layout/svg/LayoutSVGRoot.cpp View 1 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/layout/svg/SVGLayoutSupport.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/layout/svg/line/SVGInlineTextBox.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/paint/FramePainter.cpp View 5 chunks +6 lines, -6 lines 0 comments Download
M Source/core/paint/InlineFlowBoxPainter.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/paint/LayerClipRecorderTest.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/paint/LayerPainter.cpp View 1 4 chunks +4 lines, -4 lines 0 comments Download
M Source/core/paint/SVGRootPainter.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/paint/ScrollableAreaPainter.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/paint/VideoPainter.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/paint/ViewDisplayListTest.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/core/svg/graphics/SVGImage.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/accessibility/AXLayoutObject.cpp View 1 2 3 1 chunk +3 lines, -3 lines 0 comments Download
M Source/modules/accessibility/AXScrollView.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/accessibility/AXScrollbar.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/accessibility/AXSpinButton.cpp View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/geometry/LayoutRect.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/PageWidgetDelegate.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/PopupListBox.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/TextFinder.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/WebPluginContainerImpl.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/tests/WebViewTest.cpp View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (5 generated)
chrishtr
This is the rest of the call sites. I've marked the two places where pixel ...
5 years, 10 months ago (2015-02-26 18:26:47 UTC) #2
eae
LGTM
5 years, 10 months ago (2015-02-26 19:03:00 UTC) #3
leviw_travelin_and_unemployed
LGTM.
5 years, 10 months ago (2015-02-26 19:06:08 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/952273006/40001
5 years, 10 months ago (2015-02-26 20:19:23 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: blink_presubmit on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/blink_presubmit/builds/27766)
5 years, 10 months ago (2015-02-26 20:36:24 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/952273006/60001
5 years, 10 months ago (2015-02-26 20:44:30 UTC) #11
commit-bot: I haz the power
5 years, 10 months ago (2015-02-26 22:06:40 UTC) #12
Message was sent while issue was closed. 
Committed patchset #4 (id:60001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=190957

Powered by Google App Engine
This is Rietveld 408576698