Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(348)

Side by Side Diff: Source/core/layout/line/InlineFlowBox.cpp

Issue 952273006: Make the constructor of a LayoutRect from an IntRect explicit. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/core/layout/LayoutTreeAsText.cpp ('k') | Source/core/layout/svg/LayoutSVGRoot.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2009 Apple Inc. All rights reserved. 2 * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2009 Apple Inc. All rights reserved.
3 * 3 *
4 * This library is free software; you can redistribute it and/or 4 * This library is free software; you can redistribute it and/or
5 * modify it under the terms of the GNU Library General Public 5 * modify it under the terms of the GNU Library General Public
6 * License as published by the Free Software Foundation; either 6 * License as published by the Free Software Foundation; either
7 * version 2 of the License, or (at your option) any later version. 7 * version 2 of the License, or (at your option) any later version.
8 * 8 *
9 * This library is distributed in the hope that it will be useful, 9 * This library is distributed in the hope that it will be useful,
10 * but WITHOUT ANY WARRANTY; without even the implied warranty of 10 * but WITHOUT ANY WARRANTY; without even the implied warranty of
(...skipping 1029 matching lines...) Expand 10 before | Expand all | Expand 10 after
1040 } 1040 }
1041 } 1041 }
1042 // Check any culled ancestor of the final children tested. 1042 // Check any culled ancestor of the final children tested.
1043 while (culledParent && culledParent != renderer()) { 1043 while (culledParent && culledParent != renderer()) {
1044 if (culledParent->isLayoutInline() && toLayoutInline(culledParent)->hitT estCulledInline(request, result, locationInContainer, accumulatedOffset)) 1044 if (culledParent->isLayoutInline() && toLayoutInline(culledParent)->hitT estCulledInline(request, result, locationInContainer, accumulatedOffset))
1045 return true; 1045 return true;
1046 culledParent = culledParent->parent(); 1046 culledParent = culledParent->parent();
1047 } 1047 }
1048 1048
1049 // Now check ourselves. Pixel snap hit testing. 1049 // Now check ourselves. Pixel snap hit testing.
1050 LayoutRect frameRect = roundedFrameRect(); 1050 LayoutRect frameRect(roundedFrameRect());
1051 LayoutUnit minX = frameRect.x(); 1051 LayoutUnit minX = frameRect.x();
1052 LayoutUnit minY = frameRect.y(); 1052 LayoutUnit minY = frameRect.y();
1053 LayoutUnit width = frameRect.width(); 1053 LayoutUnit width = frameRect.width();
1054 LayoutUnit height = frameRect.height(); 1054 LayoutUnit height = frameRect.height();
1055 1055
1056 // Constrain our hit testing to the line top and bottom if necessary. 1056 // Constrain our hit testing to the line top and bottom if necessary.
1057 bool noQuirksMode = renderer().document().inNoQuirksMode(); 1057 bool noQuirksMode = renderer().document().inNoQuirksMode();
1058 if (!noQuirksMode && !hasTextChildren() && !(descendantsHaveSameLineHeightAn dBaseline() && hasTextDescendants())) { 1058 if (!noQuirksMode && !hasTextChildren() && !(descendantsHaveSameLineHeightAn dBaseline() && hasTextDescendants())) {
1059 RootInlineBox& rootBox = root(); 1059 RootInlineBox& rootBox = root();
1060 LayoutUnit& top = isHorizontal() ? minY : minX; 1060 LayoutUnit& top = isHorizontal() ? minY : minX;
(...skipping 272 matching lines...) Expand 10 before | Expand all | Expand 10 after
1333 ASSERT(child->prevOnLine() == prev); 1333 ASSERT(child->prevOnLine() == prev);
1334 prev = child; 1334 prev = child;
1335 } 1335 }
1336 ASSERT(prev == m_lastChild); 1336 ASSERT(prev == m_lastChild);
1337 #endif 1337 #endif
1338 } 1338 }
1339 1339
1340 #endif 1340 #endif
1341 1341
1342 } // namespace blink 1342 } // namespace blink
OLDNEW
« no previous file with comments | « Source/core/layout/LayoutTreeAsText.cpp ('k') | Source/core/layout/svg/LayoutSVGRoot.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698