Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(146)

Side by Side Diff: Source/core/frame/LocalFrame.cpp

Issue 952273006: Make the constructor of a LayoutRect from an IntRect explicit. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1998, 1999 Torben Weis <weis@kde.org> 2 * Copyright (C) 1998, 1999 Torben Weis <weis@kde.org>
3 * 1999 Lars Knoll <knoll@kde.org> 3 * 1999 Lars Knoll <knoll@kde.org>
4 * 1999 Antti Koivisto <koivisto@kde.org> 4 * 1999 Antti Koivisto <koivisto@kde.org>
5 * 2000 Simon Hausmann <hausmann@kde.org> 5 * 2000 Simon Hausmann <hausmann@kde.org>
6 * 2000 Stefan Schimanski <1Stein@gmx.de> 6 * 2000 Stefan Schimanski <1Stein@gmx.de>
7 * 2001 George Staikos <staikos@kde.org> 7 * 2001 George Staikos <staikos@kde.org>
8 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All r ights reserved. 8 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All r ights reserved.
9 * Copyright (C) 2005 Alexey Proskuryakov <ap@nypop.com> 9 * Copyright (C) 2005 Alexey Proskuryakov <ap@nypop.com>
10 * Copyright (C) 2008 Nokia Corporation and/or its subsidiary(-ies) 10 * Copyright (C) 2008 Nokia Corporation and/or its subsidiary(-ies)
(...skipping 654 matching lines...) Expand 10 before | Expand all | Expand 10 after
665 m_view->setNodeToDraw(&node); // Enable special sub-tree drawing mode. 665 m_view->setNodeToDraw(&node); // Enable special sub-tree drawing mode.
666 666
667 // Document::updateLayout may have blown away the original LayoutObject. 667 // Document::updateLayout may have blown away the original LayoutObject.
668 LayoutObject* renderer = node.renderer(); 668 LayoutObject* renderer = node.renderer();
669 if (!renderer) 669 if (!renderer)
670 return nullptr; 670 return nullptr;
671 671
672 IntRect rect; 672 IntRect rect;
673 673
674 return paintIntoDragImage(renderer->displayItemClient(), DisplayItem::ClipNo deImage, renderer->shouldRespectImageOrientation(), 674 return paintIntoDragImage(renderer->displayItemClient(), DisplayItem::ClipNo deImage, renderer->shouldRespectImageOrientation(),
675 pixelSnappedIntRect(renderer->paintingRootRect(rect))); 675 renderer->paintingRootRect(rect));
chrishtr 2015/02/26 18:26:47 No need to pixel-snap an IntRect.
676 } 676 }
677 677
678 PassOwnPtr<DragImage> LocalFrame::dragImageForSelection() 678 PassOwnPtr<DragImage> LocalFrame::dragImageForSelection()
679 { 679 {
680 if (!selection().isRange()) 680 if (!selection().isRange())
681 return nullptr; 681 return nullptr;
682 682
683 const ScopedFramePaintingState state(this, 0); 683 const ScopedFramePaintingState state(this, 0);
684 m_view->setPaintBehavior(PaintBehaviorSelectionOnly | PaintBehaviorFlattenCo mpositingLayers); 684 m_view->setPaintBehavior(PaintBehaviorSelectionOnly | PaintBehaviorFlattenCo mpositingLayers);
685 m_view->updateLayoutAndStyleForPainting(); 685 m_view->updateLayoutAndStyleForPainting();
(...skipping 152 matching lines...) Expand 10 before | Expand all | Expand 10 after
838 // We detach the FrameView's custom scroll bars as early as 838 // We detach the FrameView's custom scroll bars as early as
839 // possible to prevent m_doc->detach() from messing with the view 839 // possible to prevent m_doc->detach() from messing with the view
840 // such that its scroll bars won't be torn down. 840 // such that its scroll bars won't be torn down.
841 // 841 //
842 // FIXME: We should revisit this. 842 // FIXME: We should revisit this.
843 if (m_view) 843 if (m_view)
844 m_view->prepareForDetach(); 844 m_view->prepareForDetach();
845 } 845 }
846 846
847 } // namespace blink 847 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698