Issue 9517002: Re-enable tests that were broken due to WebKit rename of DOMWindow to Window

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9517002: Re-enable tests that were broken due to WebKit rename of DOMWindow to Window (Closed)

Created:
8 years, 9 months ago by arv (Not doing code reviews)

Modified:
8 years, 9 months ago

Reviewers:
USE chromium.org ACCOUNT, Mihai Parparita -not on Chrome, enne (OOO)

CC:
chromium-reviews, Aaron Boodman, mihaip+watch_chromium.org

Base URL:
http://git.chromium.org/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Re-enable tests that were broken due to WebKit rename of DOMWindow to Window The extension code was fixed in r123884 This is a revert of r123590. BUG=None TEST=ExtensionApiTest.GetViews:ExtensionApiTest.TabRelativeURLs:ExtensionApiTest.TabGetCurrent:ExtensionApiTest.TabReload:ExtensionApiTest.GetViewsOfCreatedPopup:ExtensionApiTest.GetViewsOfCreatedWindow:ExtensionApiTest.WebSocket:ExtensionApiTest.WindowOpener:ExtensionApiTest.MAYBE_Infobars Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=124235

Patch Set 1 #

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+11 lines, -11 lines)			Patch
M	chrome/browser/extensions/extension_get_views_apitest.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/extensions/extension_tabs_apitest.cc	View	4 chunks	+5 lines, -5 lines	0 comments	Download
M	chrome/browser/extensions/extension_websocket_apitest.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/extensions/window_open_apitest.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/infobars/infobar_extension_apitest.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/arv@chromium.org/9517002/1

8 years, 9 months ago (2012-02-29 18:18:38 UTC) #4

arv (Not doing code reviews)

8 years, 9 months ago (2012-02-29 21:33:09 UTC) #6

Only ExtensionApiTest.TabReload fails. It would have been better to just disable
that test.

Expand Messages | Collapse Messages