Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(374)

Side by Side Diff: chrome/browser/extensions/extension_tabs_apitest.cc

Issue 9517002: Re-enable tests that were broken due to WebKit rename of DOMWindow to Window (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/extensions/extension_apitest.h" 5 #include "chrome/browser/extensions/extension_apitest.h"
6 6
7 #include "chrome/browser/prefs/incognito_mode_prefs.h" 7 #include "chrome/browser/prefs/incognito_mode_prefs.h"
8 #include "chrome/browser/prefs/pref_service.h" 8 #include "chrome/browser/prefs/pref_service.h"
9 #include "chrome/browser/profiles/profile.h" 9 #include "chrome/browser/profiles/profile.h"
10 #include "chrome/browser/ui/browser.h" 10 #include "chrome/browser/ui/browser.h"
(...skipping 54 matching lines...) Expand 10 before | Expand all | Expand 10 after
65 } 65 }
66 66
67 IN_PROC_BROWSER_TEST_F(ExtensionApiTest, TabMove) { 67 IN_PROC_BROWSER_TEST_F(ExtensionApiTest, TabMove) {
68 ASSERT_TRUE(RunExtensionSubtest("tabs/basics", "move.html")) << message_; 68 ASSERT_TRUE(RunExtensionSubtest("tabs/basics", "move.html")) << message_;
69 } 69 }
70 70
71 IN_PROC_BROWSER_TEST_F(ExtensionApiTest, TabEvents) { 71 IN_PROC_BROWSER_TEST_F(ExtensionApiTest, TabEvents) {
72 ASSERT_TRUE(RunExtensionSubtest("tabs/basics", "events.html")) << message_; 72 ASSERT_TRUE(RunExtensionSubtest("tabs/basics", "events.html")) << message_;
73 } 73 }
74 74
75 IN_PROC_BROWSER_TEST_F(ExtensionApiTest, DISABLED_TabRelativeURLs) { 75 IN_PROC_BROWSER_TEST_F(ExtensionApiTest, TabRelativeURLs) {
76 ASSERT_TRUE(RunExtensionSubtest("tabs/basics", "relative_urls.html")) 76 ASSERT_TRUE(RunExtensionSubtest("tabs/basics", "relative_urls.html"))
77 << message_; 77 << message_;
78 } 78 }
79 79
80 IN_PROC_BROWSER_TEST_F(ExtensionApiTest, TabQuery) { 80 IN_PROC_BROWSER_TEST_F(ExtensionApiTest, TabQuery) {
81 ASSERT_TRUE(RunExtensionSubtest("tabs/basics", "query.html")) << message_; 81 ASSERT_TRUE(RunExtensionSubtest("tabs/basics", "query.html")) << message_;
82 } 82 }
83 83
84 IN_PROC_BROWSER_TEST_F(ExtensionApiTest, TabHighlight) { 84 IN_PROC_BROWSER_TEST_F(ExtensionApiTest, TabHighlight) {
85 ASSERT_TRUE(RunExtensionSubtest("tabs/basics", "highlight.html")) << message_; 85 ASSERT_TRUE(RunExtensionSubtest("tabs/basics", "highlight.html")) << message_;
86 } 86 }
87 87
88 IN_PROC_BROWSER_TEST_F(ExtensionApiTest, TabCrashBrowser) { 88 IN_PROC_BROWSER_TEST_F(ExtensionApiTest, TabCrashBrowser) {
89 ASSERT_TRUE(RunExtensionSubtest("tabs/basics", "crash.html")) << message_; 89 ASSERT_TRUE(RunExtensionSubtest("tabs/basics", "crash.html")) << message_;
90 } 90 }
91 91
92 IN_PROC_BROWSER_TEST_F(ExtensionApiTest, TabOpener) { 92 IN_PROC_BROWSER_TEST_F(ExtensionApiTest, TabOpener) {
93 ASSERT_TRUE(RunExtensionSubtest("tabs/basics", "opener.html")) << message_; 93 ASSERT_TRUE(RunExtensionSubtest("tabs/basics", "opener.html")) << message_;
94 } 94 }
95 95
96 IN_PROC_BROWSER_TEST_F(ExtensionApiTest, TabCurrentWindow) { 96 IN_PROC_BROWSER_TEST_F(ExtensionApiTest, TabCurrentWindow) {
97 ASSERT_TRUE(RunExtensionTest("tabs/current_window")) << message_; 97 ASSERT_TRUE(RunExtensionTest("tabs/current_window")) << message_;
98 } 98 }
99 99
100 IN_PROC_BROWSER_TEST_F(ExtensionApiTest, DISABLED_TabGetCurrent) { 100 IN_PROC_BROWSER_TEST_F(ExtensionApiTest, TabGetCurrent) {
101 ASSERT_TRUE(RunExtensionTest("tabs/get_current")) << message_; 101 ASSERT_TRUE(RunExtensionTest("tabs/get_current")) << message_;
102 } 102 }
103 103
104 // Flaky on the trybots. See http://crbug.com/96725. 104 // Flaky on the trybots. See http://crbug.com/96725.
105 IN_PROC_BROWSER_TEST_F(ExtensionApiTest, DISABLED_TabConnect) { 105 IN_PROC_BROWSER_TEST_F(ExtensionApiTest, DISABLED_TabConnect) {
106 ASSERT_TRUE(StartTestServer()); 106 ASSERT_TRUE(StartTestServer());
107 ASSERT_TRUE(RunExtensionTest("tabs/connect")) << message_; 107 ASSERT_TRUE(RunExtensionTest("tabs/connect")) << message_;
108 } 108 }
109 109
110 IN_PROC_BROWSER_TEST_F(ExtensionApiTest, MAYBE_TabOnRemoved) { 110 IN_PROC_BROWSER_TEST_F(ExtensionApiTest, MAYBE_TabOnRemoved) {
111 ASSERT_TRUE(RunExtensionTest("tabs/on_removed")) << message_; 111 ASSERT_TRUE(RunExtensionTest("tabs/on_removed")) << message_;
112 } 112 }
113 113
114 IN_PROC_BROWSER_TEST_F(ExtensionApiTest, DISABLED_TabReload) { 114 IN_PROC_BROWSER_TEST_F(ExtensionApiTest, TabReload) {
115 ASSERT_TRUE(RunExtensionTest("tabs/reload")) << message_; 115 ASSERT_TRUE(RunExtensionTest("tabs/reload")) << message_;
116 } 116 }
117 117
118 // Test is timing out on linux and cros and flaky on others. 118 // Test is timing out on linux and cros and flaky on others.
119 // See http://crbug.com/83876 119 // See http://crbug.com/83876
120 IN_PROC_BROWSER_TEST_F(ExtensionApiTest, FLAKY_CaptureVisibleTabJpeg) { 120 IN_PROC_BROWSER_TEST_F(ExtensionApiTest, FLAKY_CaptureVisibleTabJpeg) {
121 host_resolver()->AddRule("a.com", "127.0.0.1"); 121 host_resolver()->AddRule("a.com", "127.0.0.1");
122 host_resolver()->AddRule("b.com", "127.0.0.1"); 122 host_resolver()->AddRule("b.com", "127.0.0.1");
123 ASSERT_TRUE(StartTestServer()); 123 ASSERT_TRUE(StartTestServer());
124 ASSERT_TRUE(RunExtensionSubtest("tabs/capture_visible_tab", 124 ASSERT_TRUE(RunExtensionSubtest("tabs/capture_visible_tab",
(...skipping 68 matching lines...) Expand 10 before | Expand all | Expand 10 after
193 193
194 IN_PROC_BROWSER_TEST_F(ExtensionApiTest, IncognitoDisabledByPref) { 194 IN_PROC_BROWSER_TEST_F(ExtensionApiTest, IncognitoDisabledByPref) {
195 IncognitoModePrefs::SetAvailability(browser()->profile()->GetPrefs(), 195 IncognitoModePrefs::SetAvailability(browser()->profile()->GetPrefs(),
196 IncognitoModePrefs::DISABLED); 196 IncognitoModePrefs::DISABLED);
197 197
198 // This makes sure that creating an incognito window fails due to pref 198 // This makes sure that creating an incognito window fails due to pref
199 // (policy) being set. 199 // (policy) being set.
200 ASSERT_TRUE(RunExtensionTest("tabs/incognito_disabled")) << message_; 200 ASSERT_TRUE(RunExtensionTest("tabs/incognito_disabled")) << message_;
201 } 201 }
202 202
203 IN_PROC_BROWSER_TEST_F(ExtensionApiTest, DISABLED_GetViewsOfCreatedPopup) { 203 IN_PROC_BROWSER_TEST_F(ExtensionApiTest, GetViewsOfCreatedPopup) {
204 ASSERT_TRUE(RunExtensionSubtest("tabs/basics", "get_views_popup.html")) 204 ASSERT_TRUE(RunExtensionSubtest("tabs/basics", "get_views_popup.html"))
205 << message_; 205 << message_;
206 } 206 }
207 IN_PROC_BROWSER_TEST_F(ExtensionApiTest, DISABLED_GetViewsOfCreatedWindow) { 207 IN_PROC_BROWSER_TEST_F(ExtensionApiTest, GetViewsOfCreatedWindow) {
208 ASSERT_TRUE(RunExtensionSubtest("tabs/basics", "get_views_window.html")) 208 ASSERT_TRUE(RunExtensionSubtest("tabs/basics", "get_views_window.html"))
209 << message_; 209 << message_;
210 } 210 }
211 211
212 // Adding a new test? Awesome. But API tests are the old hotness. The 212 // Adding a new test? Awesome. But API tests are the old hotness. The
213 // new hotness is extension_test_utils. See extension_tabs_test.cc for 213 // new hotness is extension_test_utils. See extension_tabs_test.cc for
214 // an example. We are trying to phase out many uses of API tests as 214 // an example. We are trying to phase out many uses of API tests as
215 // they tend to be flaky. 215 // they tend to be flaky.
OLDNEW
« no previous file with comments | « chrome/browser/extensions/extension_get_views_apitest.cc ('k') | chrome/browser/extensions/extension_websocket_apitest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698