chrome/browser/extensions/extension_tabs_apitest.cc - Issue 9517002: Re-enable tests that were broken due to WebKit rename of DOMWindow to Window

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_tabs_apitest.cc

Issue 9517002: Re-enable tests that were broken due to WebKit rename of DOMWindow to Window (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Created 8 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/extension_get_views_apitest.cc ('k') | chrome/browser/extensions/extension_websocket_apitest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/extension_tabs_apitest.cc

diff --git a/chrome/browser/extensions/extension_tabs_apitest.cc b/chrome/browser/extensions/extension_tabs_apitest.cc

index f07b80d753c8e0aa38f47db77c4f3804e22350b7..e273fa93cef77eb261239de4df8cfee7075fd929 100644

--- a/chrome/browser/extensions/extension_tabs_apitest.cc

+++ b/chrome/browser/extensions/extension_tabs_apitest.cc

@@ -72,7 +72,7 @@ IN_PROC_BROWSER_TEST_F(ExtensionApiTest, TabEvents) {

ASSERT_TRUE(RunExtensionSubtest("tabs/basics", "events.html")) << message_;

}

-IN_PROC_BROWSER_TEST_F(ExtensionApiTest, DISABLED_TabRelativeURLs) {

+IN_PROC_BROWSER_TEST_F(ExtensionApiTest, TabRelativeURLs) {

ASSERT_TRUE(RunExtensionSubtest("tabs/basics", "relative_urls.html"))

<< message_;

}

@@ -97,7 +97,7 @@ IN_PROC_BROWSER_TEST_F(ExtensionApiTest, TabCurrentWindow) {

ASSERT_TRUE(RunExtensionTest("tabs/current_window")) << message_;

}

-IN_PROC_BROWSER_TEST_F(ExtensionApiTest, DISABLED_TabGetCurrent) {

+IN_PROC_BROWSER_TEST_F(ExtensionApiTest, TabGetCurrent) {

ASSERT_TRUE(RunExtensionTest("tabs/get_current")) << message_;

}

@@ -111,7 +111,7 @@ IN_PROC_BROWSER_TEST_F(ExtensionApiTest, MAYBE_TabOnRemoved) {

ASSERT_TRUE(RunExtensionTest("tabs/on_removed")) << message_;

}

-IN_PROC_BROWSER_TEST_F(ExtensionApiTest, DISABLED_TabReload) {

+IN_PROC_BROWSER_TEST_F(ExtensionApiTest, TabReload) {

ASSERT_TRUE(RunExtensionTest("tabs/reload")) << message_;

}

@@ -200,11 +200,11 @@ IN_PROC_BROWSER_TEST_F(ExtensionApiTest, IncognitoDisabledByPref) {

ASSERT_TRUE(RunExtensionTest("tabs/incognito_disabled")) << message_;

}

-IN_PROC_BROWSER_TEST_F(ExtensionApiTest, DISABLED_GetViewsOfCreatedPopup) {

+IN_PROC_BROWSER_TEST_F(ExtensionApiTest, GetViewsOfCreatedPopup) {

ASSERT_TRUE(RunExtensionSubtest("tabs/basics", "get_views_popup.html"))

<< message_;

}

-IN_PROC_BROWSER_TEST_F(ExtensionApiTest, DISABLED_GetViewsOfCreatedWindow) {

+IN_PROC_BROWSER_TEST_F(ExtensionApiTest, GetViewsOfCreatedWindow) {

ASSERT_TRUE(RunExtensionSubtest("tabs/basics", "get_views_window.html"))

<< message_;

}