tools/clang/plugins/tests/base_refcounted.cpp - Issue 951673002: Revert "Pull chromium at 2c3ffb2355a27c32f45e508ef861416b820c823b"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/clang/plugins/tests/base_refcounted.cpp

Issue 951673002: Revert "Pull chromium at 2c3ffb2355a27c32f45e508ef861416b820c823b" (Closed) Base URL: git@github.com:domokit/mojo.git@master

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/clang/plugins/tests/base_refcounted.cpp

diff --git a/tools/clang/plugins/tests/base_refcounted.cpp b/tools/clang/plugins/tests/base_refcounted.cpp

index 46e8975c597c46558be8728c094bf68d8db310fa..698bf7b952e31318995679d1e14cd1df240fad2c 100644

--- a/tools/clang/plugins/tests/base_refcounted.cpp

+++ b/tools/clang/plugins/tests/base_refcounted.cpp

@@ -13,7 +13,7 @@ class AnonymousDerivedProtectedToPublicInImpl

: public ProtectedRefCountedVirtualDtorInHeader {

public:

AnonymousDerivedProtectedToPublicInImpl() {}

- ~AnonymousDerivedProtectedToPublicInImpl() override {}

+ virtual ~AnonymousDerivedProtectedToPublicInImpl() {}

};

// Unsafe; but we should only warn on the base class.