Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(333)

Unified Diff: tools/clang/plugins/tests/base_refcounted.h

Issue 951673002: Revert "Pull chromium at 2c3ffb2355a27c32f45e508ef861416b820c823b" (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/clang/plugins/Options.h ('k') | tools/clang/plugins/tests/base_refcounted.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/clang/plugins/tests/base_refcounted.h
diff --git a/tools/clang/plugins/tests/base_refcounted.h b/tools/clang/plugins/tests/base_refcounted.h
index 4a489ee44e41761d124a99c9939080587f6faa40..4b4077c5a4a88ff2d0c97fbe7951d3476d76be7e 100644
--- a/tools/clang/plugins/tests/base_refcounted.h
+++ b/tools/clang/plugins/tests/base_refcounted.h
@@ -107,7 +107,7 @@ class DerivedProtectedToPublicInHeader
: public ProtectedRefCountedVirtualDtorInHeader {
public:
DerivedProtectedToPublicInHeader() {}
- ~DerivedProtectedToPublicInHeader() override {}
+ virtual ~DerivedProtectedToPublicInHeader() {}
};
// Unsafe; A grandchild ends up implicitly exposing their parent and
@@ -146,10 +146,10 @@ class ImplementsAPublicInterface
: public APublicInterface,
public base::RefCounted<ImplementsAPublicInterface> {
public:
- void DoFoo() override {}
+ virtual void DoFoo() override {}
protected:
- ~ImplementsAPublicInterface() override {}
+ virtual ~ImplementsAPublicInterface() {}
private:
friend class base::RefCounted<ImplementsAPublicInterface>;
@@ -165,7 +165,7 @@ class ImplementsAnImplicitInterface
: public AnImplicitInterface,
public base::RefCounted<ImplementsAnImplicitInterface> {
public:
- void DoBar() override {}
+ virtual void DoBar() override {}
private:
friend class base::RefCounted<ImplementsAnImplicitInterface>;
@@ -177,11 +177,11 @@ class PrivatelyImplementsAPublicInterface
: private APublicInterface,
public base::RefCounted<PrivatelyImplementsAPublicInterface> {
public:
- void DoFoo() override {}
+ virtual void DoFoo() override {}
private:
friend class base::RefCounted<PrivatelyImplementsAPublicInterface>;
- ~PrivatelyImplementsAPublicInterface() override {}
+ virtual ~PrivatelyImplementsAPublicInterface() {}
};
// Unsafe.
@@ -192,7 +192,7 @@ class BaseInterface {
};
class DerivedInterface : public BaseInterface {
protected:
- ~DerivedInterface() override {}
+ virtual ~DerivedInterface() {}
};
class SomeOtherInterface {
public:
@@ -211,13 +211,13 @@ class UnsafeInheritanceChain
public RefcountedType {
public:
// DerivedInterface
- void DoFoo() override {}
+ virtual void DoFoo() override {}
// SomeOtherInterface
- void DoBar() override {}
+ virtual void DoBar() override {}
protected:
- ~UnsafeInheritanceChain() override {}
+ virtual ~UnsafeInheritanceChain() {}
};
#endif // BASE_REFCOUNTED_H_
« no previous file with comments | « tools/clang/plugins/Options.h ('k') | tools/clang/plugins/tests/base_refcounted.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698