Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1310)

Unified Diff: tools/clang/plugins/tests/base_refcounted.txt

Issue 951673002: Revert "Pull chromium at 2c3ffb2355a27c32f45e508ef861416b820c823b" (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/clang/plugins/tests/base_refcounted.cpp ('k') | tools/clang/plugins/tests/missing_ctor.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/clang/plugins/tests/base_refcounted.txt
diff --git a/tools/clang/plugins/tests/base_refcounted.txt b/tools/clang/plugins/tests/base_refcounted.txt
index ae9198642cedaaaa09b06dc9b37ccdc76b036486..20c0cdf42f5efc74991e741d9bb07f7c16d5c012 100644
--- a/tools/clang/plugins/tests/base_refcounted.txt
+++ b/tools/clang/plugins/tests/base_refcounted.txt
@@ -15,7 +15,7 @@ In file included from base_refcounted.cpp:5:
~ProtectedRefCountedDtorInHeader() {}
^
./base_refcounted.h:110:3: warning: [chromium-style] Classes that are ref-counted should have destructors that are declared protected or private.
- ~DerivedProtectedToPublicInHeader() override {}
+ virtual ~DerivedProtectedToPublicInHeader() {}
^
./base_refcounted.h:107:7: note: [chromium-style] 'DerivedProtectedToPublicInHeader' inherits from 'ProtectedRefCountedVirtualDtorInHeader' here
: public ProtectedRefCountedVirtualDtorInHeader {
@@ -61,7 +61,7 @@ class AnImplicitInterface {
^
./base_refcounted.h:204:3: warning: [chromium-style] Classes that are ref-counted and have non-private destructors should declare their destructor virtual.
base_refcounted.cpp:16:3: warning: [chromium-style] Classes that are ref-counted should have destructors that are declared protected or private.
- ~AnonymousDerivedProtectedToPublicInImpl() override {}
+ virtual ~AnonymousDerivedProtectedToPublicInImpl() {}
^
base_refcounted.cpp:13:7: note: [chromium-style] 'AnonymousDerivedProtectedToPublicInImpl' inherits from 'ProtectedRefCountedVirtualDtorInHeader' here
: public ProtectedRefCountedVirtualDtorInHeader {
« no previous file with comments | « tools/clang/plugins/tests/base_refcounted.cpp ('k') | tools/clang/plugins/tests/missing_ctor.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698