Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(223)

Issue 950493003: Add a basic sky-element custom element (Closed)

Created:
5 years, 10 months ago by abarth-chromium
Modified:
5 years, 10 months ago
Reviewers:
eseidel, ojan
CC:
esprehn, mojo-reviews_chromium.org, ojan, qsr+mojo_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Add a basic sky-element custom element After this CL, you can use <sky-element> to describe custom elements. The current iteration is very basic and is hardcoded to "example", but its a start. This CL renames the |init| function to |_init| to prevent importers from calling it directly. Also, we now pass the <script> element to |_init| to give some context. R=ojan@chromium.org, eseidel@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/8cc5e112ccc4741f8c25c46a3d94f963314957cf

Patch Set 1 #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+150 lines, -18 lines) Patch
M sky/engine/core/html/parser/HTMLScriptRunner.cpp View 1 chunk +5 lines, -2 lines 2 comments Download
M sky/engine/core/script/dart_controller.h View 2 chunks +5 lines, -2 lines 0 comments Download
M sky/engine/core/script/dart_controller.cc View 4 chunks +15 lines, -5 lines 0 comments Download
A sky/examples/example-element/example-element.sky View 1 chunk +25 lines, -0 lines 2 comments Download
A + sky/examples/example-element/index.sky View 1 chunk +9 lines, -3 lines 0 comments Download
A sky/framework/sky-element.sky View 1 chunk +85 lines, -0 lines 0 comments Download
M sky/tests/modules/resources/multiple-scripts-child.sky View 2 chunks +2 lines, -2 lines 0 comments Download
M sky/tests/modules/resources/with-dart-import.sky View 1 chunk +1 line, -1 line 0 comments Download
M sky/tests/resources/dump-as-markup.sky View 1 chunk +1 line, -1 line 0 comments Download
M sky/tests/resources/dump-as-render-tree.sky View 1 chunk +1 line, -1 line 0 comments Download
M sky/tests/resources/dump-as-text.sky View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (1 generated)
abarth-chromium
5 years, 10 months ago (2015-02-20 23:59:21 UTC) #1
eseidel
We talked about _init being needed on the main sky as well. https://codereview.chromium.org/950493003/diff/1/sky/engine/core/html/parser/HTMLScriptRunner.cpp File sky/engine/core/html/parser/HTMLScriptRunner.cpp ...
5 years, 10 months ago (2015-02-21 00:08:13 UTC) #2
ojan
https://codereview.chromium.org/950493003/diff/1/sky/examples/example-element/example-element.sky File sky/examples/example-element/example-element.sky (right): https://codereview.chromium.org/950493003/diff/1/sky/examples/example-element/example-element.sky#newcode20 sky/examples/example-element/example-element.sky:20: class ExampleElement extends SkyElement { Not directly related to ...
5 years, 10 months ago (2015-02-21 00:19:16 UTC) #4
abarth-chromium
https://codereview.chromium.org/950493003/diff/1/sky/examples/example-element/example-element.sky File sky/examples/example-element/example-element.sky (right): https://codereview.chromium.org/950493003/diff/1/sky/examples/example-element/example-element.sky#newcode20 sky/examples/example-element/example-element.sky:20: class ExampleElement extends SkyElement { On 2015/02/21 at 00:19:16, ...
5 years, 10 months ago (2015-02-21 00:25:57 UTC) #5
ojan
lgtm
5 years, 10 months ago (2015-02-21 01:44:38 UTC) #6
abarth-chromium
https://codereview.chromium.org/950493003/diff/1/sky/engine/core/html/parser/HTMLScriptRunner.cpp File sky/engine/core/html/parser/HTMLScriptRunner.cpp (right): https://codereview.chromium.org/950493003/diff/1/sky/engine/core/html/parser/HTMLScriptRunner.cpp#newcode119 sky/engine/core/html/parser/HTMLScriptRunner.cpp:119: frame->dart().ExecuteLibraryInModule(module.get(), On 2015/02/21 at 00:08:13, eseidel wrote: > We ...
5 years, 10 months ago (2015-02-21 05:40:05 UTC) #7
abarth-chromium
5 years, 10 months ago (2015-02-21 05:45:41 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
8cc5e112ccc4741f8c25c46a3d94f963314957cf (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698