sky/examples/example-element/example-element.sky - Issue 950493003: Add a basic sky-element custom element

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: sky/examples/example-element/example-element.sky

Issue 950493003: Add a basic sky-element custom element (Closed) Base URL: git@github.com:domokit/mojo.git@master

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 <!--

	2 // Copyright 2015 The Chromium Authors. All rights reserved.

	3 // Use of this source code is governed by a BSD-style license that can be

	4 // found in the LICENSE file.

	5 -->

	6 <import src="/sky/framework/sky-element.sky" />

	7 <sky-element>

	8 <template>

	9 <style>

	10 div {

	11 height: 50px;

	12 width: 50px;

	13 background-color: green;

	14 }

	15 </style>

	16 <div>Hi</div>

	17 </template>

	18 <script>

	19 @tagname('example')

	20 class ExampleElement extends SkyElement {
	ojan 2015/02/21 00:19:16 Not directly related to this patch, but how hard w Not directly related to this patch, but how hard would it be to have the tag name be the class name? IMO, we should consider the implications of that. Obviously that shouldn't block this patch though. abarth-chromium 2015/02/21 00:25:57 Very easy. In fact, it would be less code than we Show quoted text On 2015/02/21 at 00:19:16, ojan wrote: > Not directly related to this patch, but how hard would it be to have the tag name be the class name? IMO, we should consider the implications of that. Obviously that shouldn't block this patch though. Very easy. In fact, it would be less code than we have currently.
	21 }

	22

	23 _init(script) => register(script, ExampleElement);

	24 </script>

	25 </sky-element>

OLD	NEW