Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1415)

Unified Diff: sky/engine/core/html/parser/HTMLScriptRunner.cpp

Issue 950493003: Add a basic sky-element custom element (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sky/engine/core/html/parser/HTMLScriptRunner.cpp
diff --git a/sky/engine/core/html/parser/HTMLScriptRunner.cpp b/sky/engine/core/html/parser/HTMLScriptRunner.cpp
index e0bab6300dbe993013f914b7da15ae6703902889..2cdb3846d357d63fb04546c2d0ffd176f7157d1f 100644
--- a/sky/engine/core/html/parser/HTMLScriptRunner.cpp
+++ b/sky/engine/core/html/parser/HTMLScriptRunner.cpp
@@ -115,8 +115,11 @@ void HTMLScriptRunner::executeLibrary(RefPtr<AbstractModule> module,
// or script failures, etc.
Microtask::performCheckpoint();
- if (LocalFrame* frame = contextFrame(m_element.get()))
- frame->dart().ExecuteLibraryInModule(module.get(), library->dart_value());
+ if (LocalFrame* frame = contextFrame(m_element.get())) {
+ frame->dart().ExecuteLibraryInModule(module.get(),
eseidel 2015/02/21 00:08:13 We should just pass the script and hang the librar
abarth-chromium 2015/02/21 05:40:05 Ok. I'll do this in a later CL.
+ library->dart_value(),
+ m_element.get());
+ }
advanceTo(StateCompleted);
// We may be deleted at this point.
« no previous file with comments | « no previous file | sky/engine/core/script/dart_controller.h » ('j') | sky/examples/example-element/example-element.sky » ('J')

Powered by Google App Engine
This is Rietveld 408576698