Add ability to specify and run post upload hooks

presubmit_support.py

 #!/usr/bin/env python
 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Enables directory-specific presubmit checks to run at upload and/or commit.
 """
 
 __version__ = '1.8.0'
 
@@ skipping 1125 matching lines @@
     function_name = 'GetPreferredTryMasters'
     if function_name not in context:
       return {}
     get_preferred_try_masters = context[function_name]
     if not len(inspect.getargspec(get_preferred_try_masters)[0]) == 2:
       raise PresubmitFailure(
           'Expected function "GetPreferredTryMasters" to take two arguments.')
     return get_preferred_try_masters(project, change)
 
 
+class GetPostUploadExecuter(object):
+  @staticmethod
+  def ExecPresubmitScript(script_text, presubmit_path, cl, change):
+    """Executes PostUploadHook() from a single presubmit script.
+
+    Args:
+      script_text: The text of the presubmit script.
+      presubmit_path: Project script to run.
+      cl: The Changelist object.
+      change: The Change object.
+
+    Return:
+      A list of results objects.
+    """
+    context = {}
+    try:
+      exec script_text in context

[iannucci, 2015/02/25 22:31:04]

:(

Though I guess since it's already PRESUBMIT.py, it's not the very worst thing :(

[rmistry, 2015/02/26 13:28:26]

Right, this also follows the same design as GetTryMastersExecuter above, so it
has consistency going for it, which is nice :)

+    except Exception, e:
+      raise PresubmitFailure('"%s" had an exception.\n%s'
+                             % (presubmit_path, e))
+
+    function_name = 'PostUploadHook'
+    if function_name not in context:
+      return {}
+    post_upload_hook = context[function_name]
+    if not len(inspect.getargspec(post_upload_hook)[0]) == 3:
+      raise PresubmitFailure(
+          'Expected function "PostUploadHook" to take three arguments.')
+    return post_upload_hook(cl, change, OutputApi(False))
+
+
 def DoGetTrySlaves(change,
                    changed_files,
                    repository_root,
                    default_presubmit,
                    project,
                    verbose,
                    output_stream):
   """Get the list of try servers from the presubmit scripts (deprecated).
 
   Args:
@@ skipping 100 matching lines @@
   # Make sets to lists again for later JSON serialization.
   for builders in results.itervalues():
     for builder in builders:
       builders[builder] = list(builders[builder])
 
   if results and verbose:
     output_stream.write('%s\n' % str(results))
   return results
 
 
+def DoPostUploadExecuter(change,
+                         cl,
+                         repository_root,
+                         verbose,
+                         output_stream):
+  """Execute the post upload hook.
+
+  Args:
+    change: The Change object.
+    cl: The Changelist object.
+    repository_root: The repository root.
+    verbose: Prints debug info.
+    output_stream: A stream to write debug output to.
+  """
+  presubmit_files = ListRelevantPresubmitFiles(
+      change.LocalPaths(), repository_root)
+  if not presubmit_files and verbose:
+    output_stream.write("Warning, no PRESUBMIT.py found.\n")
+  results = []
+  executer = GetPostUploadExecuter()
+
+  for filename in presubmit_files:

[iannucci, 2015/02/25 22:31:04]

is this in general -> specific, or specific -> general order?

e.g.

PRESUBMIT # 1
  foo/
    PRESUBMIT # 2

Does it go 2->1 or 1-2?

I'm thinking it should probably be 2->1

[rmistry, 2015/02/26 13:28:26]

Thats a good point. It was 1->2. Changed it to 2->1.

+    filename = os.path.abspath(filename)
+    if verbose:
+      output_stream.write("Running %s\n" % filename)
+    # Accept CRLF presubmit script.
+    presubmit_script = gclient_utils.FileRead(filename, 'rU')
+    results.extend(executer.ExecPresubmitScript(
+        presubmit_script, filename, cl, change))
+  output_stream.write('\n')
+  if results:
+    output_stream.write('** Post Upload Hook Messages **\n')
+  for result in results:
+    result.handle(output_stream)
+    output_stream.write('\n')
+
+  return results
+
+
 class PresubmitExecuter(object):
   def __init__(self, change, committing, rietveld_obj, verbose):
     """
     Args:
       change: The Change object.
       committing: True if 'gcl commit' is running, False if 'gcl upload' is.
       rietveld_obj: rietveld.Rietveld client object.
     """
     self.change = change
     self.committing = committing
@@ skipping 393 matching lines @@
   except PresubmitFailure, e:
     print >> sys.stderr, e
     print >> sys.stderr, 'Maybe your depot_tools is out of date?'
     print >> sys.stderr, 'If all fails, contact maruel@'
     return 2
 
 
 if __name__ == '__main__':
   fix_encoding.fix_encoding()
   sys.exit(Main(None))