Chromium Code Reviews| Index: components/cronet/android/test/javatests/src/org/chromium/net/CronetUrlRequestTest.java |
| diff --git a/components/cronet/android/test/javatests/src/org/chromium/net/CronetUrlRequestTest.java b/components/cronet/android/test/javatests/src/org/chromium/net/CronetUrlRequestTest.java |
| index d3f93ee7c1bbc686fa5a594e857dbc98e416e199..1d756ec828414526536bfc4d9b9bdaac8f2bedaa 100644 |
| --- a/components/cronet/android/test/javatests/src/org/chromium/net/CronetUrlRequestTest.java |
| +++ b/components/cronet/android/test/javatests/src/org/chromium/net/CronetUrlRequestTest.java |
| @@ -813,17 +813,23 @@ public class CronetUrlRequestTest extends CronetTestBase { |
| public void testUploadChunkedNotSupported() throws Exception { |
|
mmenke
2015/02/25 23:58:24
Rename test. :)
xunjieli
2015/02/26 20:45:57
Oops. thanks!
|
| TestUrlRequestListener listener = new TestUrlRequestListener(); |
| UrlRequest urlRequest = mActivity.mUrlRequestContext.createRequest( |
| - NativeTestServer.getRedirectToEchoBody(), listener, listener.getExecutor()); |
| + NativeTestServer.getEchoBodyURL(), listener, listener.getExecutor()); |
| TestUploadDataProvider dataProvider = new TestUploadDataProvider( |
| TestUploadDataProvider.SuccessCallbackMode.SYNC, listener.getExecutor()); |
| + dataProvider.addRead("test hello".getBytes()); |
|
mmenke
2015/02/25 23:58:24
Suggest a second test with two reads, and the seco
|
| dataProvider.setChunked(true); |
| - try { |
| - urlRequest.setUploadDataProvider(dataProvider, listener.getExecutor()); |
| - fail("Exception not thrown"); |
| - } catch (IllegalArgumentException e) { |
| - assertEquals("Chunked uploads not supported.", e.getMessage()); |
| - } |
| + urlRequest.setUploadDataProvider(dataProvider, listener.getExecutor()); |
| + urlRequest.addHeader("Content-Type", "useless/string"); |
| + |
| + assertEquals(-1, dataProvider.getLength()); |
| + |
| + urlRequest.start(); |
| + listener.blockForDone(); |
| + |
| + // 1 read call for the first data chunk, 1 for final chunk. |
| + assertEquals(2, dataProvider.getNumReadCalls()); |
| + assertEquals("test hello", listener.mResponseAsString); |
| } |
| private void throwOrCancel(FailureType failureType, ResponseStep failureStep, |