Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(364)

Unified Diff: components/cronet/android/cronet_upload_data_stream_adapter.cc

Issue 948503004: [Cronet] Enable chunked upload in CronetUrlRequest (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/cronet/android/cronet_upload_data_stream_adapter.cc
diff --git a/components/cronet/android/cronet_upload_data_stream_adapter.cc b/components/cronet/android/cronet_upload_data_stream_adapter.cc
index 05ca1ce42ad5c4ba6b840fe3ba79bea4d19c4aff..aed76f3b3f78e0303fef87dcf2ddaaf16685407b 100644
--- a/components/cronet/android/cronet_upload_data_stream_adapter.cc
+++ b/components/cronet/android/cronet_upload_data_stream_adapter.cc
@@ -87,7 +87,7 @@ void CronetUploadDataStreamAdapter::OnReadSuccess(int bytes_read,
DCHECK(read_in_progress_);
DCHECK(!rewind_in_progress_);
DCHECK(bytes_read > 0 || (final_chunk && bytes_read == 0));
- DCHECK(!is_chunked() || !final_chunk);
+// DCHECK(!is_chunked() || !final_chunk);
xunjieli 2015/02/25 22:11:11 OnReadSuccess is called for final_chunk. This DCHE
mmenke 2015/02/25 23:58:24 Yes, please change it that. The original code sho
xunjieli 2015/02/26 20:45:57 Done.
read_in_progress_ = false;

Powered by Google App Engine
This is Rietveld 408576698