net/url_request/url_request.cc - Issue 948503004: [Cronet] Enable chunked upload in CronetUrlRequest

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/url_request/url_request.cc

Issue 948503004: [Cronet] Enable chunked upload in CronetUrlRequest (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/url_request/url_request.cc

diff --git a/net/url_request/url_request.cc b/net/url_request/url_request.cc

index 752331cee8de36541c44e9a3335c21b15186cde7..aabd1368ab6079a5121150cae3fb7d5e6d0364d7 100644

--- a/net/url_request/url_request.cc

+++ b/net/url_request/url_request.cc

@@ -213,7 +213,7 @@ void URLRequest::AppendChunkToUpload(const char* bytes,

}

void URLRequest::set_upload(scoped_ptr<UploadDataStream> upload) {

- DCHECK(!upload->is_chunked());

+ // DCHECK(!upload->is_chunked());

xunjieli 2015/02/25 22:11:11 CronetUploadDataStreamAdapter is used for both chu

mmenke 2015/02/25 23:58:24 Yea, just remove this DCHECK.

upload_data_stream_ = upload.Pass();

}