Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Issue 948323002: Revert of Add support for compressed GPU memory buffers. (Closed)

Created:
5 years, 10 months ago by phoglund_chromium
Modified:
5 years, 10 months ago
CC:
cc-bugs_chromium.org, chromium-reviews, danakj+watch_chromium.org, darin-cc_chromium.org, jam, jbauman+watch_chromium.org, kalyank, piman+watch_chromium.org, sievers+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Add support for compressed GPU memory buffers. (patchset #7 id:120001 of https://codereview.chromium.org/916083002/) Reason for revert: Breaks ChromiumOS ozone compile: http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Ozone%20Builder/builds/12286/steps/compile/logs/stdio ../../ui/ozone/gpu/gpu_memory_buffer_factory_ozone_native_buffer.cc:78:11: error: 5 enumeration values not handled in switch: 'ATC', 'ATCIA', 'DXT1'... [-Werror,-Wswitch] Original issue's description: > Add support for compressed GPU memory buffers. > > This CL adds support for compressed GPU buffer formats. > > BUG=434699 > > Committed: https://crrev.com/3113db1250a2687c030585f6045f2ef242b98db6 > Cr-Commit-Position: refs/heads/master@{#317765} TBR=reveman@chromium.org,jbauman@chromium.org,piman@chromium.org,christiank@opera.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=434699 Committed: https://crrev.com/2ca19cc7c0dcc020e5faa88c3c1e09f8fa4fa157 Cr-Commit-Position: refs/heads/master@{#317769}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -335 lines) Patch
M cc/test/test_gpu_memory_buffer_manager.cc View 1 chunk +0 lines, -8 lines 0 comments Download
M content/common/gpu/client/gpu_memory_buffer_impl.cc View 3 chunks +0 lines, -16 lines 0 comments Download
M content/common/gpu/client/gpu_memory_buffer_impl_shared_memory.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M content/common/gpu/client/gpu_memory_buffer_impl_surface_texture.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M content/common/gpu/gpu_command_buffer_stub.cc View 2 chunks +0 lines, -28 lines 0 comments Download
M content/common/gpu/gpu_memory_buffer_factory_io_surface.cc View 2 chunks +0 lines, -10 lines 0 comments Download
M gpu/command_buffer/common/capabilities.h View 1 chunk +0 lines, -3 lines 0 comments Download
M gpu/command_buffer/common/capabilities.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M gpu/command_buffer/service/feature_info.h View 1 chunk +0 lines, -3 lines 0 comments Download
M gpu/command_buffer/service/feature_info.cc View 3 chunks +0 lines, -18 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M gpu/command_buffer/service/image_factory.cc View 3 chunks +0 lines, -20 lines 0 comments Download
M gpu/command_buffer/tests/gl_manager.cc View 1 chunk +0 lines, -8 lines 0 comments Download
M gpu/ipc/gpu_command_buffer_traits_multi.h View 1 chunk +0 lines, -3 lines 0 comments Download
M ui/gfx/gpu_memory_buffer.h View 1 chunk +1 line, -12 lines 0 comments Download
M ui/gl/gl_image_linux_dma_buffer.cc View 3 chunks +0 lines, -25 lines 0 comments Download
M ui/gl/gl_image_memory.h View 1 chunk +0 lines, -3 lines 0 comments Download
M ui/gl/gl_image_memory.cc View 10 chunks +32 lines, -156 lines 0 comments Download
M ui/gl/gl_image_shared_memory.cc View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
phoglund_chromium
Created Revert of Add support for compressed GPU memory buffers.
5 years, 10 months ago (2015-02-24 08:57:13 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/948323002/1
5 years, 10 months ago (2015-02-24 08:58:07 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-24 08:58:37 UTC) #3
commit-bot: I haz the power
5 years, 10 months ago (2015-02-24 08:59:16 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2ca19cc7c0dcc020e5faa88c3c1e09f8fa4fa157
Cr-Commit-Position: refs/heads/master@{#317769}

Powered by Google App Engine
This is Rietveld 408576698