Change ContentsView::SetActivePage to use States rather than indexes.

Change ContentsView::SetActivePage to use States rather than indexes.

This CL makes the ContentsView's API state-keyed rather than page index
keyed. This removes cruft from callers of SetActivePage and will
support further refactors.

BUG=455059
TBR=jamescook@chromium.org, benwells@chromium.org

Committed: https://crrev.com/a61444ac0577e22bd3b20bcee833b2d199f4f512
Cr-Commit-Position: refs/heads/master@{#321513}

[calamity, 2015-02-23 06:00:04]

calamity@chromium.org changed reviewers:
+ mgiuca@chromium.org

[Matt Giuca, 2015-02-23 23:57:27]

https://codereview.chromium.org/947903002/diff/1/ui/app_list/views/contents_v...
File ui/app_list/views/contents_view.h (right):

https://codereview.chromium.org/947903002/diff/1/ui/app_list/views/contents_v...
ui/app_list/views/contents_view.h:73: void SetActivePage(AppListModel::State
state);
I think this should be renamed to SetActiveState.

[calamity, 2015-02-24 06:40:24]

https://codereview.chromium.org/947903002/diff/1/ui/app_list/views/contents_v...
File ui/app_list/views/contents_view.h (right):

https://codereview.chromium.org/947903002/diff/1/ui/app_list/views/contents_v...
ui/app_list/views/contents_view.h:73: void SetActivePage(AppListModel::State
state);
On 2015/02/23 23:57:27, Matt Giuca wrote:
> I think this should be renamed to SetActiveState.

Done.

[Matt Giuca, 2015-02-26 23:37:11]

The CQ bit was checked by mgiuca@chromium.org

[Matt Giuca, 2015-02-26 23:37:12]

lgtm

[Matt Giuca, 2015-02-26 23:37:50]

The CQ bit was unchecked by mgiuca@chromium.org

[Matt Giuca, 2015-02-26 23:38:34]

Oops, I checked the commit box, but unchecked it because we need more owners.

Also, I think we should hold off on committing this until we're sure there won't
be any high-priority merges back to M42.

[calamity, 2015-03-20 02:23:18]

calamity@chromium.org changed reviewers:
+ benwells@chromium.org, jamescook@chromium.org

[calamity, 2015-03-20 02:23:19]

TBR-ing benwells@ for custom_launcher_page_browsertest_views.cc and jamescook@
for app_list_service_ash.cc.

[calamity, 2015-03-20 02:23:24]

The CQ bit was checked by calamity@chromium.org

[calamity, 2015-03-20 02:23:25]

The patchset sent to the CQ was uploaded after l-g-t-m from mgiuca@chromium.org
Link to the patchset: https://codereview.chromium.org/947903002/#ps100001
(title: "more_rebase")

[commit-bot: I haz the power, 2015-03-20 02:24:04]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/947903002/100001

[benwells, 2015-03-20 02:54:54]

lgtm

[commit-bot: I haz the power, 2015-03-20 04:13:30]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2015-03-20 04:14:14]

Patchset 6 (id:??) landed as
https://crrev.com/a61444ac0577e22bd3b20bcee833b2d199f4f512
Cr-Commit-Position: refs/heads/master@{#321513}

[James Cook, 2015-03-20 16:27:55]

lgtm