chrome/browser/ui/app_list/app_list_service_views.cc - Issue 947903002: Change ContentsView::SetActivePage to use States rather than indexes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/app_list/app_list_service_views.cc

Issue 947903002: Change ContentsView::SetActivePage to use States rather than indexes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: more_rebase Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/apps/custom_launcher_page_browsertest_views.cc ('k') | chrome/browser/ui/ash/app_list/app_list_service_ash.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/app_list/app_list_service_views.cc

diff --git a/chrome/browser/ui/app_list/app_list_service_views.cc b/chrome/browser/ui/app_list/app_list_service_views.cc

index 13770b2b3d0361f9f2f478f30c1598787fb231de..7f1cd4aca03e00e357a1430c91991e6793fd55f4 100644

--- a/chrome/browser/ui/app_list/app_list_service_views.cc

+++ b/chrome/browser/ui/app_list/app_list_service_views.cc

@@ -105,8 +105,8 @@ void AppListServiceViews::ShowForProfileInternal(

if (state != app_list::AppListModel::INVALID_STATE) {

app_list::ContentsView* contents_view =

shower_.app_list()->app_list_main_view()->contents_view();

- contents_view->SetActivePage(contents_view->GetPageIndexForState(state),

- shower_.IsAppListVisible() /* animate */);

+ contents_view->SetActiveState(state,

+ shower_.IsAppListVisible() /* animate */);

}

shower_.ShowForCurrentProfile();