Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(156)

Unified Diff: ui/app_list/views/contents_view.h

Issue 947903002: Change ContentsView::SetActivePage to use States rather than indexes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: more_rebase Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/app_list/views/app_list_view_unittest.cc ('k') | ui/app_list/views/contents_view.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/app_list/views/contents_view.h
diff --git a/ui/app_list/views/contents_view.h b/ui/app_list/views/contents_view.h
index 89d8d6973f048f40ee96a7f9d1f2494f290ff429..e568b351c59b89d38ea2550f6cf7f5adf43478ef 100644
--- a/ui/app_list/views/contents_view.h
+++ b/ui/app_list/views/contents_view.h
@@ -70,8 +70,8 @@ class APP_LIST_EXPORT ContentsView : public views::View,
void ShowFolderContent(AppListFolderItem* folder);
// Sets the active launcher page and animates the pages into place.
- void SetActivePage(int page_index);
- void SetActivePage(int page_index, bool animate);
+ void SetActiveState(AppListModel::State state);
+ void SetActiveState(AppListModel::State state, bool animate);
// The index of the currently active launcher page.
int GetActivePageIndex() const;
@@ -108,9 +108,6 @@ class APP_LIST_EXPORT ContentsView : public views::View,
AppListMainView* app_list_main_view() const { return app_list_main_view_; }
- // Adds a blank launcher page. For use in tests only.
- void AddBlankPageForTesting();
-
// Returns the pagination model for the ContentsView.
const PaginationModel& pagination_model() { return pagination_model_; }
@@ -166,9 +163,9 @@ class APP_LIST_EXPORT ContentsView : public views::View,
private:
// Sets the active launcher page, accounting for whether the change is for
// search results.
- void SetActivePageInternal(int page_index,
- bool show_search_results,
- bool animate);
+ void SetActiveStateInternal(int page_index,
+ bool show_search_results,
+ bool animate);
// Invoked when active view is changed.
void ActivePageChanged();
« no previous file with comments | « ui/app_list/views/app_list_view_unittest.cc ('k') | ui/app_list/views/contents_view.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698